i can't get multiple rows into array from mysql database?

Question

i can't get multiple rows into array from mysql database? i have code but it is not working or not showing all rows when i echo into textbox?

<?php 
if(is_array($_SESSION['pid']))
{
  $pid = join(',',$_SESSION['pid']); 
  $result=mysql_query("SELECT id AS wid FROM mywishlist where pid='$pid'") 
            or die("Id    Problem"."<br/><br/>".mysql_error());
  $results= array();
  $i=0; // add the new line
  while($row=mysql_fetch_array($result)){
    $results[$i] = $row['wid'];
    $i++;
  }
  $results;
}
$max=count($results);
for($j=0; $j<$max; $j++)
{
?>
<input type="text" name="wid[]" value="<?php echo $results[$j]; ?>" />
<?php } ?>

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — NullPoiиteя
– NullPoiиteя, Commented Mar 18, 2013 at 9:54
@NullPointer thanks for the support but i have another issue can u solve it please? — user2164884
– user2164884, Commented Mar 18, 2013 at 9:55
@FarhanDharsi I suspect you mean pid IN ($pid), but yes, injection is a problem here. — Joachim Isaksson
– Joachim Isaksson, Commented Mar 18, 2013 at 9:56

dfsq · Accepted Answer · 2013-03-18 09:56:34Z

2

The line join(',',$_SESSION['pid']) makes me think that you want to select multiple rows by their pid. Try to make use of IN operator:

SELECT id AS wid FROM mywishlist
WHERE pid IN ($pid)

answered Mar 18, 2013 at 9:56

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yogesh Suthar · Accepted Answer · 2013-03-18 09:57:51Z

2

your query is wrong, use this query

$result=mysql_query("SELECT id AS wid FROM mywishlist where pid IN($pid) ")

answered Mar 18, 2013 at 9:57

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

7 Comments

NullPoiиteя Over a year ago

what is difference between above answer and your ?

user2164884 Over a year ago

yogesh i used this query but results are still same only fetch one row?

Yogesh Suthar Over a year ago

@FarhanDharsi Run this query in phpmyadmin and check how many rows it returns. And also remove this line $results; after while loop.

user2164884 Over a year ago

yes i tried that query and fetching alll rows from this query ... in phpmyadmin

Yogesh Suthar Over a year ago

@FarhanDharsi after while loop use print_r($results); and see that what it contains.

|

Dipesh Parmar · Accepted Answer · 2013-03-18 09:56:55Z

1

Try

$results= array();

while($row=mysql_fetch_array($result))
{
    $results[] = $row['wid'];
}

And For Loop as.

$max = count($results);
for($j=0; $j<$max; $j++)
{
?>
    <input type="text" name="wid[]" value="<?php echo $results[$j]; ?>" />
<?php
}
?>

answered Mar 18, 2013 at 9:56

Dipesh Parmar

27.3k8 gold badges65 silver badges92 bronze badges

Collectives™ on Stack Overflow

i can't get multiple rows into array from mysql database?

3 Answers 3

Comments

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related