Add variable to end of href URL onClick JQUERY

Question

I feel like this should work, but doesn't. Not sure what I'm doing wrong.

function addURL()
{   
$(this).attr('href', function() {
return this.href + '&cylnders=12';
}   


<a onclick="addURL();" href="/search-results/?var1=red&var2=leather">Click this</a>

Christophe · Accepted Answer · 2013-03-27 05:21:28Z

32

First, you are missing a bunch of brackets:

function addURL()
{
    $(this).attr('href', function() {
        return this.href + '&cylnders=12';
    });
}

Second, in your code "this" refers to the window, not the element. Try this instead:

<a onclick="addURL(this)" href="/search-results/?var1=red&var2=leather">Click this</a>

function addURL(element)
{
    $(element).attr('href', function() {
        return this.href + '&cylnders=12';
    });
}

edited Mar 27, 2013 at 5:21

answered Mar 27, 2013 at 5:11

Christophe

28.3k29 gold badges105 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

916 Networks Over a year ago

Ah, good catch, thank you. Unfortuantely that didn't quite fix it, though syxtax error for sure.

Christophe Over a year ago

For the record you don't need jQuery: function addURL(element){element.href+='&cylnders=12';}

916 Networks Over a year ago

Does JQUERY have more overhead and potential for issues, while the javascript is much more simple and less potential for trouble?

Christophe Over a year ago

jQuery is not small, if you are just using it for this purpose it's a significant overhead. More potential for issues: no.

luchosrock · Accepted Answer · 2013-03-27 05:30:38Z

4

Why don't you add an ID or Class to your link href to identify it through jquery? It seems like your link is triggered before you can add any data to href attribute.

<a class="datalink" href="/search-results/?var1=red&var2=leather">Click this</a>
<script>

$('.datalink').attr('href', function() {
return this.href + '&cylnders=12';

});

</script>

answered Mar 27, 2013 at 5:30

luchosrock

70610 silver badges24 bronze badges

1 Comment

Hemant Over a year ago

Hi, since there is no javascript function defined for anchor tag in your example, 'return' statement won't work. Instead it should be "this.href = this.href + '&cylnders=12"

Nirmal · Accepted Answer · 2013-03-27 05:40:30Z

2

     function addURL()
      {
     var data=window.location+"&cylnders=12";
     alert(data);
     }

Try this concept. hope it will give you some solution.

Try this too

          function addURL()
          {
               window.location.href='/search-results/?var1=red&var2=leather&cylnders=12'
           }

edited Mar 27, 2013 at 5:40

answered Mar 27, 2013 at 5:17

Nirmal

2,36822 silver badges44 bronze badges

1 Comment

916 Networks Over a year ago

When I add this, I click the link and it returns my current URL with the variable appended. I guess what I'm trying to do is grab the URL in the href, add the varibale to the end, and then go to that URL.

Collectives™ on Stack Overflow

Add variable to end of href URL onClick JQUERY

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related