Javascript foreach

Question

I have a javascript for a usage graph , the data for the graph within the javascript is defined as follow:

data: [1,2,3,4,5,6],

I have before the javascript a foreach and a value that im trying to use in this data field as follow :

data: [],

Now if i just do echo "$test"; outside javascript on the page i get the following output 1,2,3,4,5,6, which is correct , if i copy this output and use it directly in the datafield it works BUT when I try to call the $test value within the datafield it does not work. So in short

data: [1,2,3,4,5,6], (WORKS)
data: [<?php echo "$test"; ?>], (does not work even though when doing normal echo outside java it does print 1,2,3,4,5,6

Any help would be appreciated

foreach ($chart->usage->days->day as $day): 
$totals = $day->total;
$datau = Round(("$totals") / (1024 * 1024 * 1024), 2);
$test = "$datau, ";

do you have an extra comma in the $test variable? for example [1,2,3,4,5,6,] ? — galchen
– galchen, Commented Mar 27, 2013 at 23:23
yes i do , but even if i copy that and input into the data field it works , example data: [1,2,3,4,5,6,], (works aswel) — Stephan Botes
– Stephan Botes, Commented Mar 27, 2013 at 23:25
try to trim the extra comma, some browsers don't like it, try [<?php echo trim($test, ','); ?>] — galchen
– galchen, Commented Mar 27, 2013 at 23:25
Trailing commas are valid per ES5 spec (only fails in IE7 and below). — Fabrício Matté
– Fabrício Matté, Commented Mar 27, 2013 at 23:26

kmoney12 · Accepted Answer · 2013-03-27 23:36:47Z

1

Try doing

$test="1,2,3,4,5,6"; //Make sure to remove a trailing comma.
data: [<?php echo $test; ?>]

I don't see any need for the "$test".

Sidenote: You can take out the echo as well. Also, since data is an array, I would store $test as an array as well.

$test=array(1,2,3,4,5,6);
data: [<?= implode(",", $test) ?>]

This looks cleaner in my opinion.

Edit: Based on your foreach, please try:

$test=array();
foreach ($chart->usage->days->day as $day){
$totals = $day->total;
$test[] = round(($totals) / (1024 * 1024 * 1024), 2);
}

data: [<?= implode(",", $test) ?>],

edited Mar 27, 2013 at 23:36

answered Mar 27, 2013 at 23:24

kmoney12

4,5005 gold badges41 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Fabrício Matté Over a year ago

String interpolation would have the same output as far as I can see.

galchen Over a year ago

but it shouldn't matter, should give the same output

kmoney12 Over a year ago

Can you tell me what var_dump($test) looks like?

Stephan Botes Over a year ago

cant do like that , ive updated my question with my foreach , maybe it will be more clear

kmoney12 Over a year ago

Okay I kind of see...but why can't you just var_dump the variable to make sure you have the right output?

|

Collectives™ on Stack Overflow

Javascript foreach

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related