PHP stacking array in another using push

Question

Could anyone explain me how to solve the following:

function GetSetClearForm(){

   $person = array('firstname' => $_POST["fname"], 'lastname' => $_POST["lname"],'age' => $_POST["age"] ,'city' => $_POST["city"] ,'zipcode' => $_POST["zcode"],'address' => $_POST["address"]);
   print_r($person);
   $personlist = array();
   array_push($personlist,$person);
   print_r($personlist);

   return $personlist;
}

When the print_r($personlist); has ran I get the following output:

 Array ( 
    [0] => Array ( 
       [firstname] => 2 
       [lastname] => 2 
       [age] => 2 
       [city] => 2 
       [zipcode] => 2 
       [address] => 2 
       ) 
    )

(filled in all textboxes with "2").

This is ok at this point, but whenever I fill in another one I get this output:

Array ( 
    [0] => Array ( 
           [firstname] => 1 
           [lastname] => 1 
           [age] => 1 
           [city] => 1 
           [zipcode] => 1 
           [address] => 1 
           ) 
     )

(filled in all textboxes with "1").

So instead of creating another person on a new index (index[1]) it replaces index[0] with a new person and deletes the older one. I dont want it do delete it I want to get a list full of people. I think it has to do with the array_push but I am not sure I hope anyone could help me out here.

EDIT:

Added the index.php:

<form action="check.php" method="POST">
<table>
<tr><td>First name</td><td><input type="text" name="fname"></td></tr>
<tr><td>Last name</td><td><input type="text" name="lname"></td></tr>
<tr><td>Age</td><td><input type="text" name="age"></td></tr>
<tr><td>City</td><td><input type="text" name="city"></td></tr>
<tr><td>Zipcode</td><td><input type="text" name="zcode"></td></tr>
<tr><td>Adress</td><td><input type="text" name="address"></td></tr>
<tr><td></td><td><input type="submit" value="Submit"></td></tr>
</table>
</form>

Added the check.php

<?php
include("functions.php");

$personlist = array();
$personlist[] = GetSetClearForm();
print_r($personlist);
?>

Read about variable scope: php.net/manual/en/language.variables.scope.php — str
– str, Commented Apr 16, 2013 at 13:40
You are stil re-iniializing person list. it will keep adding them to [0] each time the script runs. It is why I put them in the seesion. But as stated below, you might be better off saving each form entry to a database or file. — ndasusers
– ndasusers, Commented Apr 16, 2013 at 14:31

Luigi Siri · Accepted Answer · 2013-04-16 14:02:27Z

2

Instead of using array_push you can use this:

$personlist = array();
$personlist[] = $person;

This way a new index is created every time you 'insert' a new value, in this case an array.

EDIT:

You need to declare and fill your $personlist array outside your function. That said:

function GetSetClearForm(){

   $person = array('firstname' => $_POST["fname"], 'lastname' => $_POST["lname"],'age' => $_POST["age"] ,'city' => $_POST["city"] ,'zipcode' => $_POST["zcode"],'address' => $_POST["address"]);
   print_r($person);
   return $person;
 }

 $personlist = array();
 $personlist[] = GetSetClearForm();

edited Apr 16, 2013 at 14:02

answered Apr 16, 2013 at 13:47

Luigi Siri

2,0182 gold badges19 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Snifff Over a year ago

+1, actually, it is stated even in php manual: *Note*: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.

Niek Jonkman Over a year ago

unfortunately it is still placing a second (3rd,4th etc..) person array on index[0] of personlist causing the previous person to "dissolve".

Niek Jonkman Over a year ago

After edit: still replaces it, Array (personlist) [0] fname = 1 lname = 2 etc.... adding second user, Array (personlist) [0] fname = 2 lname = 2 , person 1 is gone

Luigi Siri Over a year ago

@Niek Jonkman, Are you running the script after every POST action? If that's the case, the personlist array will always be declared as a new one.

Roko C. Buljan Over a year ago

@NiekJonkman you sohuld accept (checking the "V" mark near) the Answer that helped you in your problem. It's a way to say "thanks" here on S.O.

|

ndasusers · Accepted Answer · 2013-04-16 14:27:32Z

0

I think the problem is you are re-creating person list each time the function is called. Maybe you can solve it like this:

//Create your person list some where else and keep it alive.
//Like in a session? 
session_start();


//Then give your keep alive array to your function each time.
function GetSetClearForm(){

$person = array('firstname' => $_POST["fname"], 'lastname' => $_POST["lname"],'age' => $_POST["age"] ,'city' => $_POST["city"] ,'zipcode' => $_POST["zcode"],'address' => $_POST["address"]);
print_r($person);

return $person;
}


$_SESSION['personlist'][] = GetSetClearForm() ;   
print_r( $_SESSION['personlist']);

edited Apr 16, 2013 at 14:27

answered Apr 16, 2013 at 13:52

ndasusers

7576 silver badges12 bronze badges

Collectives™ on Stack Overflow

PHP stacking array in another using push

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related