SQLAlchemy PostgreSQL Pyramid update issue

Question

I have the following model:

class Employee (Base):
    __tablename__ = 'employees'

    id       = Column(Integer, primary_key=True, autoincrement=True)
    name     = Column(String(300), unique=True, nullable=False)
    phone_a  = Column(String(20), nullable=False)
    phone_b  = Column(String(20))
    email_a  = Column(String(400), nullable=False)
    email_b  = Column(String(400))
    address  = Column(String)
    charge   = Column(String(100), nullable=False)
    active   = Column(Boolean, default=True)

    created  = Column(DateTime, nullable=False, default=datetime.datetime.now)
    modified = Column(DateTime, onupdate=datetime.datetime.now)

    def __init__(self):
        self.active  = True
        self.created = datetime.datetime.now()

    def __unicode__(self):
        return self.name

I wrote the add view for it, very basic:

employee = Employee()
form     = Form(request, EmployeeSchema(), obj = employee)

if form.validate():
    employee = form.bind(Employee())
    try:
        DBSession.add(employee)
        DBSession.flush()
        return HTTPFound(location = request.route_url('employees'))
    except IntegrityError:
        message = 'Oops!'

And it works well. But the UPDATE view doesn't. I just does not save. According to the tutorial basically with the same code it should work. But it doesn't, SQLAlchemy tries to insert a new object instead of just updating it. I tried

import transaction
transaction.commit()

But no success.

_id = request.matchdict['employeeid']
employee = DBSession.query(Employee).filter_by(id=_id).first()
form     = Form(request, EmployeeSchema(), obj = employee)

if form.validate():
    employee    = form.bind(Employee())
    try:
        DBSession.add(employee)
        return HTTPFound(location = request.route_url('employees'))
    except IntegrityError:
        message = ''

Martijn Pieters · Accepted Answer · 2013-06-07 21:34:01Z

4

You need to bind to the item, you do not need to add a new Employee() instance:

_id = request.matchdict['employeeid']
employee = DBSession.query(Employee).get(_id)
form     = Form(request, EmployeeSchema(), obj=employee)

if form.validate():
    form.bind(employee)
    return HTTPFound(location = request.route_url('employees'))

That's it.

edited Jun 7, 2013 at 21:34

answered Jun 7, 2013 at 21:28

Martijn Pieters

1.1m326 gold badges4.2k silver badges3.4k bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Mark Hildreth Over a year ago

Shouldn't you commit the session after the bind?

Martijn Pieters Over a year ago

The session is automatically committed by the pyramid transaction middleware.

Mark Hildreth Over a year ago

K. In that case, why do you need to add to the session? Isn't it already in the session using the query? Or is this another Pyramid thing?

Martijn Pieters Over a year ago

It's been a while; replaced with a merge.

kratenko Over a year ago

For everyone following this without success: Be sure to have pyramid_tm in your pyramid.includes (in your ini-file). Otherwise there will be no middleware to automatically commit. I started my project with a scaffold without DB, and it took me some time to find that problem.

|

Collectives™ on Stack Overflow

SQLAlchemy PostgreSQL Pyramid update issue

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related