Prevent object from being created in Python constructor

Question

How des one properly reject the creation of an object in a Python constructor? Consider an object:

class Triangle:
    def __init__(self, a, b, c):
        sides = [a, b, c]
        sides.sort()
        if sides[0]+sides[1] < sides[2]:
            return None
        self._a = a
        self._b = b
        self._c = c

If the sides are not logical for a triangle, I would like to reject the creation of a Triangle object. Returning None does not prevent the creation of the Triangle object, and returning False throws an exception. What is the proper way to handle this? Should I throw some type of exception when the wrong parameters are given?

Joe · Accepted Answer · 2019-03-18 11:22:01Z

11

Either raise an exception

class Triangle:
    def __init__(self, a, b, c):
        sides = [a, b, c]
        sides.sort()
        if sides[0]+sides[1] < sides[2]:
            raise ValueError('invalid triangle!')
        self._a = a
        self._b = b
        self._c = c

or use an assert (which raises an exception itself)

class Triangle:
    def __init__(self, a, b, c):
        sides = [a, b, c]
        sides.sort()
        assert sides[0]+sides[1] >= sides[2]
        self._a = a
        self._b = b
        self._c = c

Which one is more appropriate depends on if throwing on invalid values is supposed to be part of your API (first version), or only to help find programmer errors (second version, as asserts will be skipped if you pass the -O "optimized" flag to the python interpreter).

edited Mar 18, 2019 at 11:22

answered Jun 26, 2013 at 7:37

Joe

6,8474 gold badges33 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Arthur Over a year ago

I'd also add a message to the ValueError, e.g., ValueError( "Invalid triangle" )

Joe Over a year ago

@Arthur a bit late, but I added a message as per your recommendation

Sylvain Leroux · Accepted Answer · 2013-06-26 07:27:48Z

2

Returning a value (even None) from a constructor is not allowed

As you suggested, should raise an exception.

class Triangle:
    def __init__(self, a, b, c):
        sides = [a, b, c]
        sides.sort()
        if sides[0]+sides[1] < sides[2]:
            raise ValueError()
        self._a = a
        self._b = b
        self._c = c

answered Jun 26, 2013 at 7:27

Sylvain Leroux

52.4k8 gold badges114 silver badges136 bronze badges

Collectives™ on Stack Overflow

Prevent object from being created in Python constructor

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related