My javascript function gets stuck in a loop...

Question

i'm having trouble understanding where my logic fails! When I try to impose a word.length condition on pushing the word i've got from a paragraph in an array, i get stuck in an infinite loop. Please let me know your thoughts, thanks to all!

var str = document.getElementsByTagName('p')[0].innerHTML;
console.log(str);



function wordIndexes(str) {
    var result = [];
    var len = str.length;
    var i = 0, j, word;

    while (i < len) {
        if (str[i] === ' ') {
            ++i;
        }
        else {
            word = "";
            for (j = i; j < len && str[j] !== ' '; ++j) {
                word += str[j];
            }

              console.log(word.length);

            //imposing length conditions
              if (word.length < 4)
               {console.log('too short')}

              else {    
              result.push([i, word]);
              i = j;
              };


        }
    }
    return result;  
}

Could you explain in words what are you trying to achieve here? — elclanrs
– elclanrs, Commented Jul 11, 2013 at 7:28
Create a jsfiddle for this and post the link.... include data so people can play with it. jsfiddle.net — Paul
– Paul, Commented Jul 11, 2013 at 7:30
@GintasK in this code i is not part of an expression, so pre-incrementing it or post-incrementing it doesn't matter. — user1864610
– user1864610, Commented Jul 11, 2013 at 7:32

user1864610 · Accepted Answer · 2013-07-11 07:30:54Z

3

If the word length is less than 4 your code logs a message, but doesn't update i, so the next iteration starts at the same point, and fails at the same point.

I'd suggest an alternative but it's not clear how you intend to handle this condition.

answered Jul 11, 2013 at 7:30

user1864610

Sign up to request clarification or add additional context in comments.

1 Comment

Max Over a year ago

Hello mike many thanks for your answer, it was indeed the problem, and it now works

Ricola3D · Accepted Answer · 2013-07-11 07:32:24Z

0

if (word.length < 4)
{
  console.log('too short')
}
else
{
  ...

If you go in this condition, the i counter doesn't change. Check you don't go in this condition everytime

answered Jul 11, 2013 at 7:32

Ricola3D

2,46218 silver badges16 bronze badges

1 Comment

Max Over a year ago

Thank you Ric you were right also, i forgot to update to i counter. Its all fixed now!

Kevin · Accepted Answer · 2013-07-11 07:37:35Z

0

You missed i =j in your if statement

if (word.length < 4)
{
  console.log('too short')

i = j  // You missed this

}

answered Jul 11, 2013 at 7:37

Kevin

1

Collectives™ on Stack Overflow

My javascript function gets stuck in a loop...

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related