sortedArrayUsingFunction doesn't sort properly

Question

Based on an NSMutableArray of NSMutableDictionarys, I try to sort it based on a key by ascending order. the key is called Product Sale Price and it's returned from server as a string like $350. So I substring the first character to compare int values:

//Sorting function
NSInteger priceComparator(NSMutableDictionary *obj1, NSMutableDictionary *obj2, void *context){
    int v1 = [[[obj1 valueForKey:@"Product Sale Price"]substringFromIndex:1] intValue];
    int v2 = [[[obj2 valueForKey:@"Product Sale Price"]substringFromIndex:1] intValue];
    NSLog(@"v1, v2: %i | %i",v1,v2);
    if (v1 > v2){

        NSLog(@"v2 is smaller: <%i>",v2);
        return v2;
    }
    else if (v1 < v2){

        NSLog(@"v1 is smaller: <%i>",v1);
        return v1;   
    }
    else
        return NSOrderedSame;
}


//Somewhere in the code
arrayProduct = (NSMutableArray*)[arrayProduct sortedArrayUsingFunction:priceComparator context:nil];
NSLog(@"%@",arrayProduct);//The array is not sorted as expected, still random order

So basically, the order is not affected somehow although I debugged that step b step and all comparisons are correct. Am I missing something?

EDIT:

Here is some items of arrayProduct:

(
    {
        "Product ID" = 15119;
        "Product Sale Price" = "$395";
    },

    {
        "Product ID" = 16897;
        "Product Sale Price" = "$75";
    }
)

rmaddy · Accepted Answer · 2013-08-07 04:57:56Z

3

You need to return NSOrderedAscending and NSOrderedDescending instead of v1 and v2. If the sort ends up in reverse order - swap which of the two you return.

answered Aug 7, 2013 at 4:57

rmaddy

320k44 gold badges548 silver badges591 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pratik · Accepted Answer · 2013-08-07 05:05:50Z

0

you can use sort descriptor for sorting array like below code here key is key of parameter on which you want to sorting array. e.g you want to sort by name then key is "name"

NSSortDescriptor *sortDescriptor = [[[NSSortDescriptor alloc] initWithKey:@"key" ascending:YES] autorelease];
NSArray *sortDescriptors = [[NSArray alloc]init];
sortDescriptors = [NSArray arrayWithObject:sortDescriptor];
NSArray *sortedArray;
sortedArray = [Array sortedArrayUsingDescriptors:sortDescriptors];

answered Aug 7, 2013 at 5:05

Pratik

2,39918 silver badges36 bronze badges

Collectives™ on Stack Overflow

sortedArrayUsingFunction doesn't sort properly

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related