Object replaced existing object in array instead of being added

Question

Here's my code:

NSMutableArray *ratings = [[NSMutableArray alloc] init];
    NSMutableDictionary *eachRating = [[NSMutableDictionary alloc] init];

    for (UIView *subview in self.rateServiceView.subviews) {

        if ([subview isKindOfClass:[RSTapRateView class]]) {

            RSTapRateView *rs = (RSTapRateView *)subview;
            [eachRating setObject:rs.rateId forKey:@"iRatingId"];
            [eachRating setObject:[NSNumber numberWithInt:rs.rating] forKey:@"iRate"];

            [ratings addObject:eachRating];

        }

    }

Instead of getting these values:

{
        iRate = 1;
        iRatingId = 1;
    },
        {
        iRate = 5;
        iRatingId = 2;
    },
        {
        iRate = 2;
        iRatingId = 3;
    }

I'm getting these values:

{
        iRate = 2;
        iRatingId = 3;
    },
        {
        iRate = 2;
        iRatingId = 3;
    },
        {
        iRate = 2;
        iRatingId = 3;
    }

When I logged the result for each iteration, the last object replaces all the existing objects and add a new object for itself.

Michael Dautermann · Accepted Answer · 2013-08-19 08:34:03Z

2

move this line:

    NSMutableDictionary *eachRating = [[NSMutableDictionary alloc] init];

down to below this line:

    for (UIView *subview in self.rateServiceView.subviews) {

That way, you'll create a new "eachRating" dictionary which you'll add to your "ratings" array.

answered Aug 19, 2013 at 8:34

Michael Dautermann

89.7k18 gold badges174 silver badges224 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lie-An Over a year ago

great! it works fine now. Thank you so much! I'll keep this in mind :)

Nishant Tyagi · Accepted Answer · 2013-08-19 08:33:51Z

1

Yes this is because you are assigning different values to same key so new value replaces oldvalue for that key.

So change your code as :

  NSMutableArray *ratings = [[NSMutableArray alloc] init];
    for (UIView *subview in self.rateServiceView.subviews){

        if ([subview isKindOfClass:[RSTapRateView class]]) {

            NSMutableDictionary *eachRating = [[NSMutableDictionary alloc] init];


            RSTapRateView *rs = (RSTapRateView *)subview;
            [eachRating setObject:rs.rateId forKey:@"iRatingId"];
            [eachRating setObject:[NSNumber numberWithInt:rs.rating] forKey:@"iRate"];

            [ratings addObject:eachRating];

        }

    }

answered Aug 19, 2013 at 8:33

Nishant Tyagi

9,9033 gold badges42 silver badges61 bronze badges

2 Comments

Michael Dautermann Over a year ago

+1 to you Nishant, since you're really trying hard to earn that check mark. :-)

Nishant Tyagi Over a year ago

@MichaelDautermann initially I told the reason for the problem but then I thought to provide him the complete solution.

Mike Pollard · Accepted Answer · 2013-08-19 08:40:43Z

0

If you don't require further mutability of the individual dictionaries after this loop you can get a bit more modern and compact by writing it like this:

NSMutableArray *ratings = [[NSMutableArray alloc] init];

for (UIView *subview in self.rateServiceView.subviews) {

    if ([subview isKindOfClass:[RSTapRateView class]]) {

        RSTapRateView *rs = (RSTapRateView *)subview;
        [ratings addObject:@{@"iRatingId":rs.rateId, @"iRate":@(rs.rating)}];

    }

}

answered Aug 19, 2013 at 8:40

Mike Pollard

10.2k2 gold badges40 silver badges46 bronze badges

Collectives™ on Stack Overflow

Object replaced existing object in array instead of being added

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related