Batch Scripting - Finding OS Version information - Variable Output

Question

I have a script that works perfectly.

 if not exist %SystemRoot%\system32\systeminfo.exe goto warnthenexit

 systeminfo | find "OS Name" > osname.txt

 FOR /F "usebackq delims=: tokens=2" %%i IN (osname.txt) DO set vers=%%i

 echo %vers% | find "Windows 7" > nul

 if %ERRORLEVEL% == 0 goto VERSION_7

However, when I try to print the results like so:

Echo Current OS:%vers% - 64 Bit

It prints the results with a really! long gap. Like so:

Current OS:                   Microsoft Windows 7 Enterprise  - 64 Bit

Does anyone know why? or how I can remove the large gap?

Thanks a million!

dostips.com/DtTipsStringManipulation.php#Snippets.TrimLeftFOR — LittleBobbyTables - Au Revoir
– LittleBobbyTables - Au Revoir, Commented Aug 29, 2013 at 14:18
Thanks, seems that changing the : to a %Space% after the Delims seems to have worked. — level42
– level42, Commented Aug 29, 2013 at 14:26

LS_ᴅᴇᴠ · Accepted Answer · 2013-08-30 09:07:45Z

1

I know your script "works perfectly", but is not much efficient.

SYSTEMINFO takes a lot of time and osname.txt may be avoided.

Check:

FOR /F "TOKENS=1,* DELIMS==" %%u IN ('WMIC OS GET CAPTION /VALUE') DO IF /I "%%u"=="Caption" SET vers=%%v

answered Aug 30, 2013 at 9:07

LS_ᴅᴇᴠ

11.2k1 gold badge27 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Boris Dušek Over a year ago

What is more, systeminfo output is localized, including "OS Name" label itself being replaced by translation (so findstr "OS Name" will not work in non-English Windows). wmic's output, on the other hand, is not localized, so one can findstr all the way they want :-)

level42 · Accepted Answer · 2013-08-29 14:28:37Z

0

Changed

FOR /F "usebackq delims=: tokens=2" %%i IN (osname.txt) DO set vers=%%i

To

FOR /F "usebackq delims=  tokens=2" %%i IN (osname.txt) DO set vers=%%i

*Changed the : to a %space% after delims...

answered Aug 29, 2013 at 14:28

level42

9892 gold badges16 silver badges36 bronze badges

Collectives™ on Stack Overflow

Batch Scripting - Finding OS Version information - Variable Output

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related