Execute variable inside a string

Question

I am a ruby on rails developer and have a simple question which I am not able to figure out.

location.href = "/home?selected_date="+selecteddate;"&days_ago="+dateDiff(selecteddate , todaysdate);

I have to generate a URL by using the above code, here I have a variable called selecteddate which generates a value and dateDiff(selecteddate , todaysdate); does a difference of the selected date and today's date and gives me a value.

Question: When I execute it my URL looks like this:

/home?selected_date=Sun Sep 01 2013 00:00:00 GMT+0530 (IST)

I am missing the &days_ago= part. Any Idea how parse two parameters in the URL.

Thanks you in advance

notice the semicolon after selecteddate variable replace it with + sign — Tahir Yasin
– Tahir Yasin, Commented Sep 2, 2013 at 14:22
Are you sure you want to pass the date in that format? You could use selecteddate.getTime() to pass it in milliseconds. — bfavaretto
– bfavaretto, Commented Sep 2, 2013 at 14:23

score 2 · Accepted Answer · 2013-09-02 14:40:00Z

2

Your syntax is off. Plus you should encode it:

location.href = "/home?selected_date=" + encodeURIComponent(selecteddate) + "&days_ago=" + encodeURIComponent(dateDiff(selecteddate , todaysdate));

edited Sep 2, 2013 at 14:40

answered Sep 2, 2013 at 14:19

user447356

Sign up to request clarification or add additional context in comments.

2 Comments

user447356 Over a year ago

@Sergio yep, without it the URL will still be broken. :)

user2071444 Over a year ago

@ShadowWizard I think it should be encodeURIComponent not encodeUriComponent if I am not wrong

Praveen · Accepted Answer · 2013-09-02 14:19:26Z

0

you missed to concatenate.

location.href = "/home?selected_date="+selecteddate+";&days_ago="+dateDiff(selecteddate , todaysdate);

answered Sep 2, 2013 at 14:19

Praveen

56.7k35 gold badges137 silver badges169 bronze badges

Comments

Yair Nevet · Accepted Answer · 2013-09-02 14:20:42Z

0

Try this code:

location.href = "/home?selected_date="+selecteddate+"&days_ago="+dateDiff(selecteddate , todaysdate);

The problem is that you're not concatenate the selecteddate string variable.

answered Sep 2, 2013 at 14:20

Yair Nevet

13.1k17 gold badges71 silver badges111 bronze badges

Collectives™ on Stack Overflow

Execute variable inside a string

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related