Getting php result in mysql

Question

I tried using this function to return a MySQL result in PHP. I ran the query in PhpMyAdmin and it ran successfully. But when I try to run it in PHP, nothing is returned.

My table is structured like this:

<table>
    <tr>
    <td>Setting</td>
    <td>Value</td>
    </tr>
    <tr>
    <td>Setting</td>
    <td>stylesheet.css</td>
    </tr>
</table>

Function:

function getData()
{
require 'config.php';
$con = mysql_connect($hostname, $username, $password, $database);
$sql = "SELECT Value FROM Settings WHERE Setting = 'Stylesheet'";
$result = mysql_query($con,$sql);
$row = mysql_result($result, 0);
mysqli_close($con);
return $row;
}

Update: Still not working

function getData()
{
require 'config.php';
$con = mysql_connect($hostname, $username, $password, $database);
$sql = "SELECT Value FROM Settings WHERE Setting = 'Stylesheet'";
$result = mysql_query($sql, $con);
$row = mysql_result($result, 0);
mysql_close($con);
return $row;
}

You're closing your connection before returning your $row - place it on top of mysqli_close($con); so that mysqli_close($con); is your last line. — Funk Forty Niner
– Funk Forty Niner, Commented Sep 5, 2013 at 1:21
please print_r(getData()); and show me result.Avoid require inside your function — Charaf JRA
– Charaf JRA, Commented Sep 5, 2013 at 1:24
@Fred-ii- no difference,if he puts close statement after return ,this statement wouldn't execute and connection will not be closed — Charaf JRA
– Charaf JRA, Commented Sep 5, 2013 at 1:26
shouldnt the mysql_query() function be mysql_query($sql, $con);? and to close shouldnt it be mysql_close($con);? edit:: i think that is why it isnt returning.. it isnt completing the function due to the syntax errors — Ryan Hurling
– Ryan Hurling, Commented Sep 5, 2013 at 1:32

Ryan Hurling · Accepted Answer · 2013-09-05 01:41:35Z

2

Shouldn't the mysql_query() function be mysql_query($sql, $con);?

And to close shouldn't it be mysql_close($con);?

Edit: i think that is reason why it isn't returning.. It isnt completing the function due to the syntax errors.

edited Sep 5, 2013 at 1:41

answered Sep 5, 2013 at 1:35

Ryan Hurling

2873 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dejan Marjanović · Accepted Answer · 2013-09-05 01:45:58Z

1

You are mixing mysql_* and mysqli_*. You don't need to specify connection if there is only one for mysql_*.

Function [ <internal:mysql> function mysql_query ] {

  - Parameters [2] {
    Parameter #0 [ <required> $query ]
    Parameter #1 [ <optional> $link_identifier ]
  }
}

If you can't use e.g. PDO, consider refactoring your function:

require 'config.php';
$con = mysql_connect($hostname, $username, $password, $database);

function getData()
{
  $sql = "SELECT Value FROM Settings WHERE Setting = 'Stylesheet'";
  $result = mysql_query($sql);
  $row = mysql_result($result, 0);
  return $row;
}

Connection is closed at the end of request, you are just making unnecessary connect/disconnect actions.

answered Sep 5, 2013 at 1:45

Dejan Marjanović

19.4k7 gold badges54 silver badges67 bronze badges

3 Comments

Funk Forty Niner Over a year ago

I also mentioned something to the affect earlier, about the connection being closed, but that theory was quickly shot down.

Dejan Marjanović Over a year ago

@Fred-ii- You thought that nothing is returned because he closed connection before return, that's not true since the result is in $row and that's all it matters. I was trying to say that he only needs to connect to db once per request. mysql_close is not necessary since it's closed automatically (unless he specifically wants/have a reason).

Funk Forty Niner Over a year ago

Ok I understand, thanks for clearing that up. I misunderstood "Connection is closed at the end of request, you are just making unnecessary connect/disconnect actions." in your answer, that's why I said that.

Morgan Green · Accepted Answer · 2014-04-30 06:04:24Z

    class MySQL {
    var $ServerURL='localhost';
    var $ServerPort='3306';
    var $DataBaseName='test';
    var $DataBaseUser='root';
    var $DataBasePass='';
    public function __construct() {
        $this->mysqli = new mysqli($this->ServerURL,$this->DataBaseUser,$this->DataBasePass,$this->DataBaseName,$this->ServerPort);
        if (mysqli_connect_errno()) {
            printf('failed to connect');
            }
        else {
            }


    }

    }
    $MySQL = new MySQL;

       require 'config.php';
class Data extends MySQL {
     function getData()
        {
        $this->sql = "SELECT Value FROM Settings WHERE Setting = 'Stylesheet'";
        $result = mysqli_query($this->mysqli, $this->sql);
        $this->row = mysql_result($this->result, 0);
        return $this->row;

        }
$Data = new Data;

Collectives™ on Stack Overflow

Getting php result in mysql

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related