string operations, for loop doesnt work

Question

I have written this to get the index of first character of string s1 which has come in string s2, but doesn't give the correct answer and every time it throws different wrong answers, anyone knows why?

s1 = input ('enter the s1 string: ')
s2 = input ('enter the s2 string: ')
for i in range (0, len(s1)):
    if s1[i] in s2:
        n= (s1.index(s1[i]))
    else:
        n= -1
print (n)

falsetru · Accepted Answer · 2013-09-08 18:46:20Z

2

You should stop iteration when match found:

s1 = input('enter the s1 string: ')
s2 = input('enter the s2 string: ')
n = -1
for i in range(0, len(s1)):
    if s1[i] in s2:
        n = i # Stop iteration when match character found.
        break
print(n)

Just reference i instead of s1.index(s1[i]).

answered Sep 8, 2013 at 18:46

falsetru

371k69 gold badges770 silver badges660 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

string operations, for loop doesnt work

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related