Foreach within a while loop

Question

I'm having an issue with a foreach loop iterating its entire array contents in each instance of the while loop.

I've tried moving the loop, adding break & continue points and using alternate syntaxes-- I feel like I'm just missing something small here. Do I need to further define the array? Do I integrate the foreach loop into the while somehow? Any pointers would be much appreciated. Here is a basic run down of the code (using "Shopp" an ecommerce plugin with a similar code example at: https://shopplugin.net/api/shopp_cart_items/):

<?php  while(shopp('cart','items')): // initializes the shopping cart loop

           $Items = shopp_cart_items(); 
            foreach ( $Items as $item ):

        echo $item->quantity * $item->weight; // multiplies weight by quantity

                endforeach; echo 'g'; endwhile; ?>

The products are measured in weight, so as an example, there are 2 items in the cart with their weights at 1 gram, and 2 grams respectively.

Here's the current output:

Cart item 1 - Weight: 12g
Cart item 2 - Weight: 12g

Here's the expected output:

Cart item 1 - Weight: 1g
Cart item 2 - Weight: 2g

Thanks in advance!

IH

Edit:

There is no documentation in Shopp concerning product weight, so I had to find the product object and arrays and added an ++ operator to cycle through them with each while iteration. Here is the code I used.

echo $Items[$i++]->option->dimensions['weight'] * shopp('cartitem','quantity', 'echo=false');

with the integer set outside the loop: $i = 0;

I don't understand why there are two looping structures in play here. What is your intent in doing that? — Mike Brant
– Mike Brant, Commented Sep 9, 2013 at 21:41
Looks like you are printing both item weight for each item. Seems that only one loop would be enough — Joqus
– Joqus, Commented Sep 9, 2013 at 21:42
Drop the while(shopp(...)) line. That call does nothing but confuse you. The example you site doesn't even show the while loop. — Rottingham
– Rottingham, Commented Sep 9, 2013 at 21:45
The first loop is the cart items loop, where each cart item's details are instanced. It does seem logical that only one loop is required, but using the code "echo $item->quantity * $item->weight;" without the loop doesn't return anything! — user2762858
– user2762858, Commented Sep 10, 2013 at 18:45

Chris Pierce · Accepted Answer · 2013-09-09 21:56:24Z

0

echo $item->quantity * $item->weight; // multiplies weight by quantity

is probably returning improperly, but could be as simple as

echo ($item->quantity * $item->weight);

I'd also recommend using something besides Item as $item $Item and $items is getting really confusing to look at.

answered Sep 9, 2013 at 21:56

Chris Pierce

7365 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hakre Over a year ago

operand operator operand - there is nothing which is ambiguous with such expressions - no parenthesis required.

RST · Accepted Answer · 2015-05-26 10:07:24Z

0

another approach

  $product_id = shopp('cartitem.get-product');
  $weight = shopp('product.get-weight'); // use product tag to get weight
  $quantity = shopp('cartitem.get-quantity'); // use cart-item tag to get quantity
  echo $weight * $quantity .' g';

edited May 26, 2015 at 10:07

answered Aug 12, 2014 at 20:17

RST

3,9252 gold badges24 silver badges33 bronze badges

2 Comments

Tharok Over a year ago

It looks you are mixing old syntax (shopp('cart','items')) togather with new syntax (shopp('cart.items')). New syntax of cart.items is exampled here: shopplugin.net/api/cart-hasitems

RST Over a year ago

I have adjusted it, but there is no old and new syntax. The 'new' one is just a shorthand version. Mixing the two doesn't result in errors. When you look at the core Shopp code you will find both notations are used. Eventually every shopp() command in the core code will be replaced with the shorthand version of course.

Collectives™ on Stack Overflow

Foreach within a while loop

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related