Can't return data from factory to controller AngularJS

Question

I am having trouble returning data from a factory method to a controller.

service.js

var serverFac = angular.module('serverCom', []).factory('SmsSendService', function($http){

var transform = function(data){
    return $.param(data);
}

var temp = {};
temp.sendSms = function(tempJs){
    $http.post("http://localhost:8080/somepath/rest/text-messages/send/batch", tempJs ,{
        transformRequest: transform
    }).success(function(data, status, headers, config){
        //do stuff with response
    });
};

temp.login = function (tempUserPassword){
    $http.post("http://localhost:8080/somepath/rest/users/authenticate", tempUserPassword ,{
           transformRequest: transform
        }).success(function(data, status, headers, config){
            //do stuff with response
        }). error(function(data, status, headers, config){
            console.log(status);
        });
    };


temp.SimList = function (){
    $http.get("http://localhost:8080/RetireesClub_server/rest/sim-cards"
        ).success(function(data, status, headers, config){
            //do stuff with response

        }). error(function(data, status, headers, config){

        });
};


    return temp;
});

serverFac.config(function($httpProvider){
    delete $httpProvider.defaults.headers.common['X-Requested-With'];
    $httpProvider.defaults.headers.post['Content-Type'] = 'application/x-www-form-   urlencoded;charset=utf-8';
});

controller.js

function SimListController($scope, SmsSendService, SearchData, Search , $dialog , $location,$filter ){
    smsSendService.simList().success(function(data){
        $scope.sims= data;
    }
}

Well, I used to use $rootScope.$broadcast('you.event', you.data) method to send data to a scope. And in controller you can write $scope.$on('you.event', function (evt, data) { ... }) Actually, in my opinion this is one of the best practice. Thus, your modules are totally separated. — Ivan Demchenko
– Ivan Demchenko, Commented Sep 12, 2013 at 14:16
Are you missing some code, where is the function simList()? — Mark Coleman
– Mark Coleman, Commented Sep 12, 2013 at 14:18

AlwaysALearner · Accepted Answer · 2013-09-12 14:33:43Z

2

Since you are handling the success callback in the controller, make your service function return a promise:

temp.SimList = function (){
    return $http.get("http://localhost:8080/RetireesClub_server/rest/sim-cards")
};

answered Sep 12, 2013 at 14:33

AlwaysALearner

43.9k9 gold badges98 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Can't return data from factory to controller AngularJS

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related