Return in recursive function php

Question

I've got a little problem with recursive function output. Here's the code:

function getTemplate($id) {
    global $templates;
    $arr = $templates[$id-1];
    if($arr['parentId'] != 0) {
        $arr['text'] .= str_replace($arr['attr'], $arr['text'], getTemplate($arr['parentId']));
    }
    return $arr['text']; 
}

The problem is that that function returns a value on each iteration like this:

file.exe
category / file.exe
root / category / file.exe

And I need only the last string which resembles full path. Any suggestions?

//UPD: done, the problem was with the dot in $arr['text'] .= str_replace

@sashkello it is sure a recursive function, because it calls itself. — sybear
– sybear, Commented Sep 17, 2013 at 12:03
if you are working with directories and files have a look at RecursiveDirectoryIterator() php.net/manual/es/class.recursivedirectoryiterator.php — aleation
– aleation, Commented Sep 17, 2013 at 12:03
@sash - a function that calls itself must be under the term recursive — davidkonrad
– davidkonrad, Commented Sep 17, 2013 at 12:03
This code would be much much better if it didn't use a global. There's no need for it, and it adds unnecessary complication. — Spudley
– Spudley, Commented Sep 17, 2013 at 12:05

asarfraz · Accepted Answer · 2013-09-17 12:34:47Z

1

Try this please. I know its using global variable but I think this should work

$arrGlobal = array();

function getTemplate($id) {
    global $templates;
    global $arrGlobal;

    $arr = $templates[$id-1];
    if($arr['parentId'] != 0) {
       array_push($arrGlobal, getTemplate($arr['parentId']));
    }
    return $arr['text'];
}

$arrGlobal = array_reverse($arrGlobal);

echo implode('/',$arrGlobal);

answered Sep 17, 2013 at 12:34

asarfraz

5183 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

bigbobr Over a year ago

i've found the problem in my code, it was the dot in $arr['text'] .= thanks for your response, it worked too ;)

asarfraz Over a year ago

Thank you for your comment :) Can you mark my solution as useful so it may help some one else

Santosh Pradhan · Accepted Answer · 2013-09-17 12:12:00Z

0

Try this,

function getTemplate($id) {
    global $templates;
    $arr = $templates[$id-1];
    if($arr['parentId'] != 0) {
    return $arr['text'] .= str_replace($arr['attr'], $arr['text'], getTemplate($arr['parentId']));
    }
}

answered Sep 17, 2013 at 12:12

Santosh Pradhan

1491 gold badge1 silver badge11 bronze badges

3 Comments

bigbobr Over a year ago

that function outputs the same thing without the last string which i need.

Santosh Pradhan Over a year ago

One thing I want to know, does $arr['parentId'] != 0 means it will stop iterating here ?

bigbobr Over a year ago

$arr['parentId']=0 means that this is the root folder; we don't need to go deeper and the function start replacing the text.

AlexP · Accepted Answer · 2013-09-17 12:26:24Z

0

Give this a try:

function getTemplate($id, array $templates = array())
{
  $index = $id - 1;
  if (isset($templates[$index])) {
    $template = $templates[$index];
    if (isset($template['parentId']) && $template['parentId'] != 0) {
      $parent = getTemplate($template['parentId'], $templates);
      $template['text'] .= str_replace($template['attr'], $template['text'], $parent);
    }
    return $template['text'];
  }
  return '';
}

$test = getTemplate(123, $templates);

echo $test;

answered Sep 17, 2013 at 12:26

AlexP

9,8571 gold badge28 silver badges44 bronze badges

2 Comments

bigbobr Over a year ago

same result with my function, returns on each iteration

AlexP Over a year ago

@bigbobr In my example $test will hold the entire string. The function will need to return each value in order to be used recursively. Please update your question showing where you are using the function. It shouldn't be used within a loop or you will overwrite the value of $test on each iteration.

Collectives™ on Stack Overflow

Return in recursive function php

3 Answers 3

2 Comments

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related