Repeating output of an array

Question

    $timein_out = $this->time_model->get_timein_out($this->input->get('i'));   

    $total_diff= array();
    $hours = array();
    $mins =array();

    foreach($timein_out as $timetest)
     {
        $total_diff[] = strtotime($timetest["Time_out"]) - strtotime($timetest["Time_in"]);

        for($key=0;$key<count($total_diff);$key++)
        {
            $hours[] = intval(floor($total_diff[$key]/3600));
            $mins[] =  intval(($total_diff[$key]-$hours[$key]*3600)/60); 
        }

     };

     echo json_encode($total_diff); // output: [33600,34560,35160]
     echo json_encode($hours); // [9,9,9,9,9,9]
     echo json_encode($mins); //[20,20,36,20,36,46]

The actual output should be

 echo json_encode($hours); // [9,9,9,]
 echo json_encode($mins); //[20,36,46]

Question: Why is the output repeating? what is the problem in my code? :( thanks.

what is the value of $timein_out?

bansi
– bansi

2013-09-23 03:21:05 +00:00
Commented Sep 23, 2013 at 3:21 — bansi
– bansi, Commented Sep 23, 2013 at 3:21

bansi · Accepted Answer · 2013-09-23 03:23:19Z

3

may be you want the inner loop outside. try this.

 foreach($timein_out as $timetest)
 {
    $total_diff[] = strtotime($timetest["Time_out"]) - strtotime($timetest["Time_in"]);

 }
 for($key=0;$key<count($total_diff);$key++)
 {
     $hours[] = intval(floor($total_diff[$key]/3600));
     $mins[] =  intval(($total_diff[$key]-$hours[$key]*3600)/60); 
 }

answered Sep 23, 2013 at 3:23

bansi

57.3k6 gold badges44 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rajeev Ranjan Over a year ago

+1 better approach than the accepted answer.its run for 2n times and accepted answer runs for n*n times....

bot Over a year ago

yeah.. i think this one is faster than the other one.. :)

Sudhir Bastakoti · Accepted Answer · 2013-09-23 03:20:45Z

1

may be try unset()'ting the $total_diff like:

foreach($timein_out as $timetest) {
    $total_diff[] = strtotime($timetest["Time_out"]) - strtotime($timetest["Time_in"]);

    for($key=0;$key<count($total_diff);$key++) {
        $hours[] = intval(floor($total_diff[$key]/3600));
        $mins[] =  intval(($total_diff[$key]-$hours[$key]*3600)/60); 
    }
    unset($total_diff);
}

answered Sep 23, 2013 at 3:20

Sudhir Bastakoti

100k15 gold badges163 silver badges169 bronze badges

1 Comment

bot Over a year ago

sorry dude i think the other one is much faster.

Collectives™ on Stack Overflow

Repeating output of an array

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related