Codeigniter checking checkbox value

Question

I'm using CodeIgniter and I have a form with a checkbox that allows the user to check and remove their uploaded photo.
In my controller I use if(isset($checked) == 1) to check if the user wants to remove the photo.
$photo_to_table will set empty and pass to $this->tank_auth->update_user() to perform db update, and set photo field to become empty in table. Otherwise, it will remain the same photo.

But in my code, whether I check it or not, when I click UPDATE button, it keeps removing the photo, I wonder why is it happening?

Can someone please go through my code and give an advise?

Controller:

$user_id = $this->session->userdata('user_id');
$profile = $this->users->get_profile_by_id($user_id);

if(!empty($_FILES['photo']['name'])) 
{
    //image upload process
}
else
{
    $checked = $this->input->post('remove');
    if(isset($checked) == 1)
        {
            $photo_to_table = '';
            // here will do remove process to delete file in directory
        }
    else
    {
        $photo_to_table = $profile->photo;
    }
}

    if($this->form_validation->run()) { // validation ok
    if(!is_null($data = $this->tank_auth->update_user(
        $this->form_validation->set_value('name'),
        $this->form_validation->set_value('country'),
        $this->form_validation->set_value('website'),
        $photo_to_table
        ))) 
    { 
        // success
        $this->session->set_flashdata('msg', 'Profile has been updated');
        redirect(current_url());
    }
}

View:

<?php echo form_open_multipart($this->uri->uri_string()); ?>
<table border="0">

<?php
if(!empty($uphoto)){
?>
    <tr>
        <td>
            <div>
                <img src="<?php echo base_url().$userpath.$uphoto; ?>" />
           </div>

           <div>
               <input id="remove" type="checkbox" name="remove">
               <label for="remove">Remove photo</label>
           </div>
       </td>
   </tr>
<?php
}
?>

Thanks.

TigerTiger · Accepted Answer · 2013-09-25 06:47:27Z

8

What you need to do here is to change this line ...

if(isset($checked) == 1){

to

if((int) $checked == 1){

The reason is that the variable $checked will always be set whether its value is 1 or not. $checked = $this->input->post('remove'); will return NULL if the 'remove' is not set in the POST data.

answered Sep 25, 2013 at 6:47

TigerTiger

10.8k16 gold badges59 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Roopendra · Accepted Answer · 2013-09-25 06:47:29Z

3

Please write proper value in your checkbox :-

   <input id="remove" type="checkbox" name="remove">

Write some value then check it :-

for e.g :

  <input id="remove" type="checkbox" name="remove" value="1">

In php :-

   if($checked == 1) {
      // do whatever u want
   }

edited Sep 25, 2013 at 6:47

answered Sep 25, 2013 at 6:39

Roopendra

7,76716 gold badges72 silver badges95 bronze badges

Comments

Nil'z · Accepted Answer · 2013-09-25 06:39:53Z

1

Try:

<input id="remove" type="checkbox" name="remove" value="1">

answered Sep 25, 2013 at 6:39

Nil'z

7,4831 gold badge20 silver badges28 bronze badges

1 Comment

conmen Over a year ago

I added value="1", is still same.

Jhonathan H. · Accepted Answer · 2013-09-25 06:53:27Z

1

remove isset

its because by default in your CI Controller you get input value using

$checked = $this->input->post('remove');

whether is has a value or not your variable now exist..

answered Sep 25, 2013 at 6:53

Jhonathan H.

2,7131 gold badge21 silver badges28 bronze badges

Comments

Pang · Accepted Answer · 2018-09-04 09:56:17Z

0

Use this if it can help.

$checked = (isset($_POST['checkbox']))?true:false;

edited Sep 4, 2018 at 9:56

Pang

10.2k146 gold badges87 silver badges126 bronze badges

answered Sep 4, 2018 at 9:27

Olizy

415 bronze badges

Collectives™ on Stack Overflow

Codeigniter checking checkbox value

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related