Error Using std::vector<std::string> myString

Question

Hi it's a little bit hard for me to understand what the compiler is saying:

[BCC32 Error] frmNew.cpp(333): E2285 Could not find a match for 'std::getline<_Elem,_Traits,_Alloc>(ifstream,std::vectorstd::string,std::allocator<std::string >)' Full parser context frmNew.cpp(303): parsing: void _fastcall TFrmNewPeta::showDefaultRute()

I'm using std::vector<std::string>mystring to store my strings file, but while (std::getline(ifs_Awal, mystring)) throws the error.

This is my complete code:

    void __fastcall TFrmNewPeta::showDefaultRute()
    {
        std::string mystring;
        std::ifstream ifs_Awal;
        int tempIndexAwal = 0;
        ifs_Awal.open("DefaultDataAwal");
        while (std::getline(ifs_Awal, mystring)) {++tempIndexAwal;}
        std::vector<std::string> mystring(tempIndexAwal);
        while (std::getline(ifs_Awal, mystring)) // error
        {
            mystring.push_back(mystring); // error
        }
        ifs_Awal.close();
    }

I'm using C++ Builder 2010.

In many tutorials they prefer to using std::vector to store a string to a dynamic array. So I did the same thing, but the error occurred when I tried using std::vector<>.

billz · Accepted Answer · 2013-10-06 09:36:09Z

3

second parameter of std::getline could be std::string but not std::vector<std::string>. It's quite clear as error message shows.

update

std::vector<std::string> mystring(tempIndexAwal);

to:

std::string mystring;

You do not post how you declare myline, I suppose it's std::vector<std::string>.

edited Oct 6, 2013 at 9:36

answered Oct 6, 2013 at 9:20

billz

45.6k9 gold badges87 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adhy · Accepted Answer · 2013-10-06 10:42:06Z

1

billz and tomi rights your passing wrong argument so I change your code. should be

    void __fastcall TFrmNewPeta::showDefaultRute() {
    std::string lines;
    std::ifstream ifs_Awal;
    int tempIndexAwal = 0;
    ifs_Awal.open("DefaultDataAwal");

    /*get the strings and counting the lines*/
    while(std::getline(ifs_Awal,lines)){++tempIndexAwal;}

    std::vector<std::string> mystring(tempIndexAwal);

    while(std::getline(ifs_Awal,lines)) //put your 'lines' here
    {
        mystring.push_back(lines); // theres no error again :)
    }
    ifs_Awal.close();
    }

edited Oct 6, 2013 at 10:42

answered Oct 6, 2013 at 10:29

Adhy

922 silver badges10 bronze badges

2 Comments

Bika Shad Over a year ago

thanks for change my code to be the correct answer. I've been do the same way as you answer. thanks

Adhy Over a year ago

I'm so glad if that's you want. also you can use the members functions of the vector at() to shown the element. example std::cout<<mystring.at(0)<<endl;

tomi.lee.jones · Accepted Answer · 2013-10-06 09:29:12Z

1

Your passing wrong argument to getline.

mystring is not a std::string as it should be, but a std::vector. Thus line std::getline(ifs_Awal,mystring) causes an error since the second argument is not std::string.

Also, line

myline.push_back(mystring)

does not work because myline is probably a vector of string, and you try to push an element of vector<string> to it.

So, as suggested already, changing myline to std::string is the answer.

edited Oct 6, 2013 at 9:29

answered Oct 6, 2013 at 9:23

tomi.lee.jones

1,5531 gold badge15 silver badges22 bronze badges

1 Comment

Bika Shad Over a year ago

Hi @Tomi.lee.jones, I realize I'm wrong declare using mystring as string to use as vector. so I change my code as you suggest and its works, Thanks for your advice

Collectives™ on Stack Overflow

Error Using std::vector<std::string> myString

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related