How to loop through an array that's been created from user input c#

Question

Well I'm trying to make a simple program that takes advantage of a for loop and adds user input to an array one at a time, this uses this

string []str = new string[10];
for (int i = 0; i < str.Length; i++)
{
     Console.WriteLine("Please enter a number: ");
     str[i] = Console.ReadLine();
}

But When i try and loop through the array with a foreach statement, i get an error stating that i can't implicitly convert string[] to type String; the foreach statement is this:

int even=0; int odd=0;

int[] Arr=new string [] {str};

foreach (int i in Arr)
{
    if (i % 2 == 0)
    {
        even++;
    }
    else
    {
        odd++;
    }
}

And here is the full source,

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleApplication1
{
    class Program
    {
        static void Main(string[] args)
        {
            string[] str = new string[10];
            for (int i = 0; i < str.Length; i++)
            {
                Console.WriteLine("Please enter a number: ");
                str[i] = Console.ReadLine();
            }
            int even = 0; int odd = 0;
            int[] Arr = new string[] { str };
            foreach (int i in Arr)
            {
                if (i % 2 == 0)
                {
                    even++;
                }
                else
                {
                    odd++;
                }
            }
            Console.WriteLine("There is " + even + " even numbers.");
            Console.WriteLine("There is " + odd + " odd numbers");
            Console.ReadLine();
            Console.ReadLine();
        }
    }
}

Because you create an integer array and try to fill/initialize it with strings. Check your second line of code in the second codebox — Daniel Abou Chleih
– Daniel Abou Chleih, Commented Oct 20, 2013 at 20:33

Steve · Accepted Answer · 2013-10-20 20:34:46Z

2

Change your input code to save the user input directly in an array of integers instead of strings

    int i = 0;
    int[]values = new int[10];
    while(i < values.Length)
    {
        Console.WriteLine("Please enter a number: ");
        int result;
        string input = Console.ReadLine();
        if(Int32.TryParse(input, out result)
        {
            values[i] = result;
            i++;
        }
        else
        { 
            Console.WriteLine("Not a valid integer");
        }
    }

This will avoid the error when in this line int[] Arr=new string [] {str}; you try to initialize an array of integers from an array of strings and the compiler is not happy with it

Apart from the obvious compilation error, using Int32.TryParse allows to check immediately if the user types something that is not an integer and you can deny the input

answered Oct 20, 2013 at 20:34

Steve

217k22 gold badges242 silver badges296 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2819245 Over a year ago

Small nitpicking: str itself is a string[]. So, he actually tried to add a string[] as element to a string[]... Spinning heads... :)

Steve Over a year ago

Fine, but you have accepted another one, so this is not really good for you

Hossain Muctadir · Accepted Answer · 2013-10-20 20:41:40Z

0

In the line below you are trying to create an integer array from all your input. But actually this kind of syntax is not correct. Firstly you are trying to create an array of int out of array of string. This is not possible. Secondly a string array is created like new string[]{"str", "str"} but you are doing new string[]{str[]}. So to solve all these issues i recommend replace

int[] Arr=new string [] {str};

with

int[] Arr = str.Select(s => int.Parse(s)).ToArray();

edited Oct 20, 2013 at 20:41

answered Oct 20, 2013 at 20:36

Hossain Muctadir

3,6361 gold badge22 silver badges33 bronze badges

Collectives™ on Stack Overflow

How to loop through an array that's been created from user input c#

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related