Using .click() rather than inline onclick

Question

I have always went with the inline onclick approach as such:

<a href="#" id="do-something" onclick="doSomething(<?= $row['id'] ?>); return false;">

But I notice this isn't what the majority of websites do. They tend to do this:

<a href="#" id="do-something">

$("#do-something").click(function(e) {
    e.preventDefault();
    doSomething();
    // --------^
})

The only problem is, how do I get the parameter that I supplied in example one so I can use it in example two? What's the correct process? Maybe add some hidden divs?

btw, that's a good read on the subject: stackoverflow.com/questions/12627443/jquery-click-vs-onclick — Leon
– Leon, Commented Nov 4, 2013 at 20:15
@Leon Thanks for the post. I ran across that post multiple times while a was searching for an answer! — SeanWM
– SeanWM, Commented Nov 4, 2013 at 20:20

tymeJV · Accepted Answer · 2013-11-04 20:10:54Z

5

Assign that value to a custom data attribute, something like data-row="<? php ... ?>". Now access it with: $(this).data("row");

answered Nov 4, 2013 at 20:10

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

SeanWM Over a year ago

Ah yes, I've seen that. I wasn't sure if that was the "correct" way to do it. Is there anything I should be aware about before doing this?

tymeJV Over a year ago

Ehh... nothing out of the ordinary, data-* is just a custom attribute that will pass HTML validation, perfect for something like this.

Matt Sach · Accepted Answer · 2013-11-04 20:17:34Z

0

One way might be to use data attributes, like this:

<a href="#" id="do-something" data-row="<?= $row['id'] ?>">

And then this function:

$("#do-something").click(function(e) {
    var row = $(this).data('row');
    e.preventDefault();
    doSomething(row);
});

answered Nov 4, 2013 at 20:17

Matt Sach

1,17216 silver badges37 bronze badges

Collectives™ on Stack Overflow

Using .click() rather than inline onclick

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related