Using variables PHP

Question

So, this is part of the code in my sendemail.php and it works perfectly:

$email = $_POST["email"];

$headers = "MIME-Version: 1.0" . "\r\n";
$headers .= "Content-type:text/html;charset=iso-8859-1" . "\r\n";
$headers .= 'From: <[email protected]'>' . "\r\n";

When trying to edit the From: to the email received from my form the script suddently it doesn't work. Could you help me?

I tried this:

$email = $_POST["email"];

$headers = "MIME-Version: 1.0" . "\r\n";
$headers .= "Content-type:text/html;charset=iso-8859-1" . "\r\n";
$headers .= 'From: <"$email">' . "\r\n";

John Conde · Accepted Answer · 2013-11-11 00:49:54Z

1

The problem is this line:

$headers .= 'From: <"$email">' . "\r\n";

It should be:

$headers .= 'From: <"' . $email . '">' . "\r\n";

Because the contents of the variable are in single quotes, $email becomes a literal "$email" which is at least causing problem with receiving the email as spam filters will usually raise a red flag when it sees this.

answered Nov 11, 2013 at 0:49

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Jason McCreary Over a year ago

+ for speed, but you should add more detail.

John Conde Over a year ago

Was in the process of doing it as you wrote this. :)

Sebbo Over a year ago

Hmm, the email hasn't reched it's destination, however it does when hardcoding an email adress insted of using $email.

John Conde Over a year ago

That's explained in my answer so I am unsure what you're trying to say

Sebbo Over a year ago

Ohh, missed that one, but how do I make this without the single quotes then?

|

Giacomo1968 · Accepted Answer · 2013-11-11 18:07:05Z

0

Another way to deal with variables in highly formatted content is to use sprintf:

So the example that John Conde gives looks like this:

$headers .= 'From: <"' . $email . '">' . "\r\n";

But using sprintf it would look like this:

$headers .= sprintf('From: <"%s">' . "\r\n", $email);

The benefit is you do not have to worry about balancing quotes. And since the variables are always at the end of the line, it makes it a tad easier to review for debugging in my opinion.

EDIT: Also, since this formats it better but is still not sending (according to the original poster’s comments) try the following variations instead. No quotes:

$headers .= sprintf('From: <%s>' . "\r\n", $email);

No < and >:

$headers .= sprintf('From: %s' . "\r\n", $email);

edited Nov 11, 2013 at 18:07

answered Nov 11, 2013 at 1:00

Giacomo1968

25.3k11 gold badges78 silver badges106 bronze badges

2 Comments

Sebbo Over a year ago

The email doesn't get sent, however it does when hardcoding an example email adress.

Sebbo Over a year ago

Still no success, this is weird.. This is the default W3Schools sample that works perfectly: $headers .= 'From: <[email protected]>' . "\r\n";

Collectives™ on Stack Overflow

Using variables PHP

2 Answers 2

6 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related