php + href redirection

Question

I have next code in my home.php file:

<html>    
    <body>
    <table border="3">
        <tr><td>
            <a href="?page=my_page_1">Page 1</a>
        </td></tr>

        <tr><td>
            <a href="?page=my_page_2">Page 2</a>
        </td></tr>

    </table>

    <?php
        if(isset($_GET['page'])){
            $page = $_GET['page'];
            $filename = $page.'.php';

            if(file_exists($filename)){
                include($filename);
            }
            else{
                echo("File does not exist");
            }
        }
        else{
            echo("Page does not set");
        }
    ?>
    </body>    
</html>

I'am expecting to page being reloaded as a certain .php file when one of the links is getting pressed. But, by some reason, nothing happens instead. Files "my_page_1.php" and "my_page_2.php" does exist and are located in the same folder with "home.php". I guess it doesn't work as I think it should, so could someone explain me what is really happening when links are getting pressed?

Probably be easier to make use of case, but that's just me. — Funk Forty Niner
– Funk Forty Niner, Commented Nov 22, 2013 at 20:37
@MikeBrant I don't think home.php is required when the link is called from home.php(though it is good practice). I could be mistaken, though. — will
– will, Commented Nov 22, 2013 at 20:45
@Mike Brant, when I do click on those links my new link is "pathToFolder/home.php?page=my_page_x" — Anton
– Anton, Commented Nov 22, 2013 at 20:48

Thornuko · Accepted Answer · 2013-11-22 20:46:07Z

1

Have you thought about using

header("Location: $filename");

That will reload the page on the new url.

answered Nov 22, 2013 at 20:46

Thornuko

2871 silver badge4 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Anton Over a year ago

I guess I could just set my href's as href="my_page_x.php" and it will work, but my aim is to understand why does this code doesn't work when it should (it's simplified example from one of the youtube tutorials)

Asta · Accepted Answer · 2013-11-22 21:49:01Z

0

You need to have your server configured in order to allow links that start with ?page. Otherwise you will need to add the current url as suggested in the comments.

You can checkout Apache mod_rewrite for more details. A better approach in using mod_rewrite would be to keep the page name but remove the extension i.e home?page=my_page_x. This is more flexible and allows search friendly and more readable urls.

Note: In production you shouldn't include a file from a GET variable like that as it opens up a lot of security issues.

answered Nov 22, 2013 at 21:49

Asta

1,58913 silver badges23 bronze badges

1 Comment

Anton Over a year ago

well, my server is my own PC with windows on it -_- btw, thx for GET tip

Anton · Accepted Answer · 2013-11-23 00:20:42Z

0

Seems like php would be executed only on and by the server and not as a simple script by your browser.

answered Nov 23, 2013 at 0:20

Anton

352 silver badges5 bronze badges

Collectives™ on Stack Overflow

php + href redirection

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related