How to unit test a method that creates a Zend\Db\Sql\Sql object?

Question

I have this method that I would like to unit test. Since it's creating the Sql object inside the method, I can't mock it.

Initially I thought about making Sql be an instance property except that I'd have to reset it every time I use it in other methods and this will most likely lead to hard to debug errors (I don't want the possibility to get a "dirty" Sql object on other subsequent calls to its getter if at all avoidable).

What's the common pattern for testing these kinds of methods?

public function getConfigFromDb()
{
    if (!is_null($this->configInDb)) {
        return $this->configInDb;
    }

    $sql = new Sql($this->getSlaveDbAdapter());

    $select = $sql->select()
                  ->from('mytable');

    $statement = $sql->prepareStatementForSqlObject($select);
    $results   = $statement->execute();
    $results->buffer();

    $this->configInDb = $return;

    return $results;
}

In your case, I would add a SqlFactory and register it as a service (in factories param in service manager config), that way you can easily mock the service and the objects you'll get from it. — SmasherHell
– SmasherHell, Commented Dec 12, 2013 at 8:49
@SmasherHell why did you post this as a comment instead of an answer? This looks perfectly reasonable. — Julian
– Julian, Commented Dec 12, 2013 at 18:50

SmasherHell · Accepted Answer · 2013-12-13 16:33:13Z

1

@Julian you're right, I'll put it as an answer

In this case, I would add a SqlFactory and register it as a service (in factories param in service manager config), that way you can easily mock the service and the objects you'll get from it.

To go further on the subject, I delegate all object creation to factories that I can call using ServiceManager. The fact is, that way, I can test my Factory in isolation, injecting all dependencies it needs, asserting that the actual object created is the expected object. And anytime I need an object from Factory in the method tested, I can serve a real instance, or a Mock.

answered Dec 13, 2013 at 16:33

SmasherHell

8849 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to unit test a method that creates a Zend\Db\Sql\Sql object?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related