Return error to angular ajax request from MVC web API

Question

Ive used couple of days trying to figugure out how to return an error to angular ajax request to web api.

in my js AccountController i have a login method:

$scope.Login = function () {
    AccountService.Login($scope.UserData.LoginName, $scope.UserData.Password).success(function (account) {
        $scope.UserData = account;
    }).error(function () {
        console.log("failed");
    });
};

and in web api i have folowing:

public Account Login(string loginName, string password) 
{ 
    var emptyAccount = new Account(); 
    password = Encrypt(password);
    var account = db.Accounts.FirstOrDefault(c=>c.Password == password && c.LoginName == loginName);

    if (account == null)
    {
        throw new HttpResponseException(Request.CreateResponse(HttpStatusCode.NotFound));
    }

    acount.Password = "";
    return account;
}

The problem is that i throw a new HttpResponseException which fire off and dont return anything back to ajax. How do i fix this?

Darin Dimitrov · Accepted Answer · 2013-12-27 10:34:41Z

2

Normally, in this case it is the error handler that will get triggered.

.error(function () {
    alert("login failed");
}

This is where you could handle the error.

Also you probably want to return 401 Unauthorized in this case instead of 404. Also in general it is considered bad practice to throw exceptions in cases where you can handle it gracefully:

public HttpResponseMessage Login(string loginName, string password)
{
    var emptyAccount = new Account();
    password = Encrypt(password);
    var account = db.Accounts.FirstOrDefault(c => c.Password == password && c.LoginName == loginName);

    if (account == null)
    {
        return Request.CreateErrorResponse(HttpStatusCode.Unauthorized, "unauthorized");
    }

    acount.Password = "";
    return Request.CreateResponse(HttpStatusCode.OK, account);
}

answered Dec 27, 2013 at 10:34

Darin Dimitrov

1.0m277 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Timsen Over a year ago

Oh thanks that was exactly what i wanted, was almost about to give up on that

reptildarat · Accepted Answer · 2013-12-27 10:40:09Z

When you sending the data, and it's hit the servers, it will return header 200 OK because it's already hit your controller, even when your controller code is throw error (in later process).

so, if you want to know what error that thrown, I will create AccountResponse Dto into that, and introduce new Error field in that like so:

public class AccountResponse()
{
    public Account account { get; set;}
    public string ErrorMessage { get; set; }
}

and then on the controller:

public AccountResponse Login(string loginName, string password) 
{ 
    var emptyAccount = new Account(); 
    password = Encrypt(password);
    var account = db.Accounts.FirstOrDefault(c=>c.Password == password && c.LoginName == loginName);

    if (account == null)
    {
        return new AccountResponse(){ ErrorMessage = Response.ResponseCodes.something;
    }

    AccountResponse.account = account;
    AccountResponse.account.Password = "";
    return AccountResponse;
}

Collectives™ on Stack Overflow

Return error to angular ajax request from MVC web API

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related