Query fails when getting data from MySQL database

Question

I'm trying to get data from an database that I have created in phpMyAdmin. My problem is that however I change my query I'm getting the same type of error message using the mysql_error() function:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''foods'' at line 1

PHP code index file:

<?php
require 'connect.inc.php';

$query = "SELECT 'food_type', 'calories' FROM 'foods'";

if($query_run = mysql_query($query)){

    while ($query_row = mysql_fetch_assoc($query_run)){
        $food = $query_row('food_type');
        $calories = $query_row('calories');

        echo $food.' has '.$calories.' calories ';
    }
}else{
    echo mysql_error();
}
?>

PHP code database connection file:

<?php
$connectionError = 'Can\'t connect.';

$mySqlHost = 'localhost';
$mySqlUser = 'root';
$mySqlPassword = 'Bhu8Nji9';

$mySqlDataBase = 'my_first_database';

if(!@mysql_connect($mySqlHost, $mySqlUser, $mySqlPassword) || !@mysql_select_db($mySqlDataBase)){
    die($connectionError);
}else{
    //echo 'Connected';
}
?>

In your query, swap those apostrophes for backticks. Since none of them are reserved words, you can get away with removing them too. — halfer
– halfer, Commented Dec 31, 2013 at 9:36

Shankar Narayana Damodaran · Accepted Answer · 2013-12-31 09:36:17Z

1

Rewrite your query [Use Backticks instead of Single quotes]

$query = "SELECT 'food_type', 'calories' FROM 'foods'";

to

$query = "SELECT `food_type`, `calories` FROM foods";

answered Dec 31, 2013 at 9:36

Shankar Narayana Damodaran

68.6k43 gold badges102 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Strawberry Over a year ago

Or just SELECT food_type, calories FROM foods - and now change your password.

Shankar Narayana Damodaran Over a year ago

@Strawberry, Yes but it is always a good practice to enclose the columns under backticks.

Strawberry Over a year ago

It is good practice, but it's also incredibly irritating IMHO. A better idea is to avoid the use of reserved words.

Shankar Narayana Damodaran Over a year ago

@Strawberry, Exactly. +1

GOPI · Accepted Answer · 2013-12-31 09:53:55Z

1

use this..

$result = mysql_query("SELECT food_type,calories FROM foods");
while($row = mysql_fetch_array($result))
{...}

edited Dec 31, 2013 at 9:53

answered Dec 31, 2013 at 9:43

GOPI

1,0608 silver badges30 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:49:40Z

0

Do not use single quotes around table name and field names.

$query = "SELECT food_type, calories FROM foods";

Also avoid mysql_* functions.

Why shouldn't I use mysql_* functions in PHP?

Read following to know when or why to use backticks

Using backticks around field names

edited May 23, 2017 at 11:49

CommunityBot

11 silver badge

answered Dec 31, 2013 at 9:37

chanchal118

3,6672 gold badges30 silver badges55 bronze badges

Comments

Krish R · Accepted Answer · 2013-12-31 09:37:10Z

0

Can you try this, added backticks in table foods

$query = "SELECT food_type, calories FROM `foods`";

answered Dec 31, 2013 at 9:37

Krish R

22.7k7 gold badges54 silver badges60 bronze badges

Comments

Dinesh · Accepted Answer · 2013-12-31 09:37:21Z

0

It is a problem regarding of unknown column name you should use backtick as:

$query = "SELECT `food_type`, `calories` FROM foods";

answered Dec 31, 2013 at 9:37

Dinesh

4,1145 gold badges24 silver badges35 bronze badges

Comments

Adarsh Nahar · Accepted Answer · 2013-12-31 09:57:32Z

0

There is a syntax error in your query. It should be as below,

$query = "SELECT food_type, calories FROM `foods`";

answered Dec 31, 2013 at 9:57

Adarsh Nahar

3193 silver badges10 bronze badges

Collectives™ on Stack Overflow

Query fails when getting data from MySQL database

6 Answers 6

4 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

4 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related