php add to database with insert statment

Question

I have a simple insert statement that should use $GLOBALS that has my connection string in. Problem is that it does not insert the data. Have I done this correctly?

Insert.php

<?php
require 'core/init.php';

$Name = $_REQUEST["Name"];
$Venue = $_REQUEST["Venue"];
$Category = $_REQUEST["Category"];

$query = "INSERT INTO bands (Name, Venue, Category)
          VALUES ('$Name', '$Venue', '$Category')";
mysql_query ($query,$GLOBALS)
    or die ("could not add to database");

echo("You have added: <br />");
$result = mysql_query("SELECT * FROM bands ORDER  BY  Band_id DESC LIMIT 1");

while($row = mysql_fetch_array($result))
{
    echo $row['Name']. "" . $row['Venue']. "" . $row['Category'];
    echo "<br />";
}
?>

What error do you get? What have you done to troubleshoot this? — John Conde
– John Conde, Commented Jan 17, 2014 at 14:30
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. You are also wide open to SQL injections — John Conde
– John Conde, Commented Jan 17, 2014 at 14:31
I am just getting the message "could not add to database", I have run it through a compiler and there are no errors. how would I run further checks? — Beep
– Beep, Commented Jan 17, 2014 at 14:32
I know you are starting, but don't use mysql_* library and don't use $_REQUEST. — Rich Bradshaw
– Rich Bradshaw, Commented Jan 17, 2014 at 14:43

Tutcugil · Accepted Answer · 2014-01-17 14:37:57Z

1

You need to connect mysql with mysql_connect() function then select database with mysql_select_db() function then you can call mysql_query function

you just cant execute queries with query string parameter you need to execute that connection query first and then select your database

And i suggest you to use mysqli instead of mysql cuz mysql methods will be deprecated soon

answered Jan 17, 2014 at 14:37

Tutcugil

3584 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

John Conde · Accepted Answer · 2014-01-17 14:32:32Z

0

You don't put whole $GLOBALS variable in your mysql_query() call. You put the specific variable with the connection string only:

mysql_query($query, $GLOBALS['connection']) // Assuming you called the connection var "connection"
    or die ("could not add to database");

answered Jan 17, 2014 at 14:32

John Conde

220k100 gold badges464 silver badges504 bronze badges

Collectives™ on Stack Overflow

php add to database with insert statment

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related