how to create a group of radio buttons with JavaScript?

Question

Does anyone know why this simple program doesn't work? It's a program that creates a group of radio buttons with Javascript.

<html>
  <head>
    <script>
      function onWriteRadio(Valuse,numButtons,RadioName){
        for(i=0;i<numButtons;i++){
          document.write("<input type='radio' name=" + RadioName + "value="       +Valuse[i]+"/>");
          document.write("<br/>");
        }
      }
    </script>
  </head>

  <body onload="onWriteRadio([red,green,blue],3,'color')>

  </body>
</html>

james emanon · Accepted Answer · 2014-01-21 09:27:58Z

5

use this:

onWriteRadio(['red','green','blue'],3,'color')

string the array values. Currently, you say [red,green,blue], that means the variable red, variable green, variable blue, BUT you don't define them anywhere, so your program is saying "hmm, i do not know what red is.".. so string em.

answered Jan 21, 2014 at 9:27

james emanon

11.9k12 gold badges70 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sajad Karuthedath · Accepted Answer · 2014-01-21 09:28:41Z

2

put array values in quotes

onWriteRadio(['red','green','blue'],3,'color')

answered Jan 21, 2014 at 9:28

Sajad Karuthedath

16.2k4 gold badges35 silver badges50 bronze badges

Comments

Dilip D · Accepted Answer · 2017-04-11 17:34:03Z

1

you left some quotation marks.

function onWriteRadio(values, radioName){
    
          for (var i = 0; i < values.length; i++) {
        document.write("<input type='radio' name='" + radioName + "' value='" +values[i]+"' >"+values[i]+" </ input>");
        document.write("<br/>");
    }
    }

<html>
  <body onload="onWriteRadio(['red', 'green', 'blue'], 'color')">

  </body>
</html>

edited Apr 11, 2017 at 17:34

Dilip D

5751 gold badge5 silver badges28 bronze badges

answered Jan 21, 2014 at 9:44

Marc Rubiño

7357 silver badges8 bronze badges

Comments

Linga · Accepted Answer · 2014-01-21 09:27:44Z

0

document.write() writes HTML expressions or JavaScript code to a document, which replaes your earlier html content.

document.write() executed after the page has finished loading will overwrite the page, or write a new page.

document.write() is a bad practice

answered Jan 21, 2014 at 9:27

Linga

10.6k10 gold badges57 silver badges109 bronze badges

Comments

Denis O. · Accepted Answer · 2014-01-21 09:37:15Z

0

place array values in quotes
add closing double quote for onload
make one string containing all inputs code and then write it

Your code should look smthng like this:

<html>
<head>
<script>
function onWriteRadio(Valuse,numButtons,RadioName){
    var s = '';
    for(i=0;i<numButtons;i++){
        s += "<input type='radio' name=" + RadioName + "value="       +Valuse[i]+"/>"
    }
    document.write(s);
}
</script>
</head>
<body onload="onWriteRadio(['red','green','blue'],3,'color')">
</body>
</html>

edited Jan 21, 2014 at 9:37

answered Jan 21, 2014 at 9:30

Denis O.

1,85020 silver badges40 bronze badges

Collectives™ on Stack Overflow

how to create a group of radio buttons with JavaScript?

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related