Using classes and functions

Question

I have a question when it comes to using classes, constructors and functions

I'm trying to use json_encode and echo the array out. Can anyone point me in the correct direction here? I don't really know what I'm doing wrong, I thought it was correct but I guess not. Any and all help is appreciated. Thanks.

No errors or output.

class information
{

    public $motd, $owner, $greeting;
    public $array;

    function __construct($motd, $owner, $greeting){
        $this->motd = $motd;
        $this->owner = $owner;
        $this->greeting = $greeting;
    }

    function test(){
       $array = array(
        'motd' => $motd,
        'owner' => $owner,
        'greeting' => $greeting
       );
       $pretty = json_encode($array);
       echo $pretty;
    }

}


$api = new information('lolol','losslol','lololol');
$api->test;
?>

and you array will be empty should be: motd' => $this->motd, 'owner' => $this->owner, 'greeting' => $this->greeting — Steve
– Steve, Commented Jan 22, 2014 at 20:18
Remember to read a lot of code, and test a lot more. In that way you will learn better than asking for help at the first issue. — Lucio
– Lucio, Commented Jan 22, 2014 at 20:19

ComFreek · Accepted Answer · 2014-01-22 20:17:54Z

3

Two mistakes:

You're missing $this:

$array = array(
  'motd' => $this->motd,
  'owner' => $this->owner,
  'greeting' => $this->greeting
);

You need to call $api->test().
Your current code only evalutes $api->test (which results in a reference to a function) and throws the value away.

answered Jan 22, 2014 at 20:17

ComFreek

29.5k18 gold badges107 silver badges157 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

BlueFireMedia Over a year ago

This was my problem, I'm sorry this was probably a waste of a post. Thank you.

ComFreek Over a year ago

@BlueFireMedia No problem, but please remember to accept an answer for every question you posted: how does accepting an answer work? (if there is an answer which seems sufficient for you)

elixenide · Accepted Answer · 2014-01-22 20:18:37Z

1

You need to call the test method, and you need to refer to variables correctly:

class information
{

    public $motd, $owner, $greeting;
    public $array;

    function __construct($motd, $owner, $greeting){
        $this->motd = $motd;
        $this->owner = $owner;
        $this->greeting = $greeting;
    }

    function test(){
       $array = array(
        'motd' => $this->motd,  // note the $this->
        'owner' => $this->owner,  // note the $this->
        'greeting' => $this->greeting  // note the $this->
       );
       $pretty = json_encode($array);
       echo $pretty;
    }

}


$api = new information('lolol','losslol','lololol');
$api->test(); // note the ()
?>

answered Jan 22, 2014 at 20:18

elixenide

44.9k16 gold badges79 silver badges103 bronze badges

Collectives™ on Stack Overflow

Using classes and functions

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related