Passing an array of data into a SQLite Database in android

Question

I am using an array to send data to my SQLite Database.
The array contains all the selected values.

 private void addContacts(String[] selectedItems) {

    manager.Insert_phone_contact(selectedItems);
    Intent i = new Intent(this, MainActivity.class);    
    startActivity(i);
}

My SQLite databse code to insert the above mentioned "selectedItems" array in contentvalues is as follows:

public void Insert_phone_contact(String [] contact){
    try{

        SQLiteDatabase DB = this.getWritableDatabase();
        for(int i=0;i<contact.length;i++){
            ContentValues cv = new ContentValues();
            cv.put(CONTACT_NAME, contact[i]);
            DB.insert(TABLE_CONTACTS, null, cv);
            DB.close();
        }
        }
    catch(Exception ex){
        Log.e("Error in phone contact insertion", ex.toString());
    }

Only the first array item is stored in ContentValues cv, not all the array elements.
What's wrong in this code?
How can I insert all the array items in the "TABLE_CONTACTS" table?
Any help will be appreciated.

DareDevil · Accepted Answer · 2014-02-03 05:54:47Z

7

You have to fix few lines of code, First is to delete Db.Close() and add it after loop The code you were trying was closing the Db object after first insertion and unavailable for the rest of loop iterations.

public void Insert_phone_contact(String [] contact){
try{

    SQLiteDatabase DB = this.getWritableDatabase();
    ContentValues cv = new ContentValues(); //Declare once
    for(int i=0;i<contact.length;i++){            
        cv.put(CONTACT_NAME, contact[i]);
        DB.insert(TABLE_CONTACTS, null, cv); //Insert each time for loop count            
    }
    DB.close(); // Now close the DB Object
    }
catch(Exception ex){
    Log.e("Error in phone contact insertion", ex.toString());
}

answered Feb 3, 2014 at 5:54

DareDevil

5,3498 gold badges53 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ρяσѕρєя K · Accepted Answer · 2014-02-02 16:39:52Z

3

You will need to move insert and close statement outside for loop because currently you are storing only one value and not opening db again :

   ContentValues cv = new ContentValues();
    for(int i=0;i<contact.length;i++){
       // put all values in  ContentValues
        cv.put(CONTACT_NAME, contact[i]);
    }
    DB.insert(TABLE_CONTACTS, null, cv); // insert in db
    DB.close();  // call close

answered Feb 2, 2014 at 16:39

ρяσѕρєя K

133k54 gold badges203 silver badges216 bronze badges

Comments

Pankaj Zanzane · Accepted Answer · 2014-02-03 06:27:07Z

2

You can also consider transactions in sqlite

    DB.beginTransaction();
    for(int i=0;i<contact.length;i++){    
        ContentValues cv = new ContentValues();  
        cv.put(CONTACT_NAME, contact[i]);
        DB.insert(TABLE_CONTACTS, "0.0", cv);
    }
    DB.setTransactionSuccessful();

    DB.endTransaction();

This will make insert operation faster than single insert

answered Feb 3, 2014 at 6:27

Pankaj Zanzane

1,2421 gold badge9 silver badges22 bronze badges

1 Comment

John T Over a year ago

This reduced the time from 1 minute to two secs for me.

MalhotraUrmil · Accepted Answer · 2016-09-02 12:04:43Z

0

you can using code i have just some changes your code.

public void Insert_phone_contact(String [] contact){
try{

    SQLiteDatabase DB = this.getWritableDatabase();
    for(int i=0;i<contact.length;i++){
        ContentValues cv = new ContentValues();
        cv.put(CONTACT_NAME, contact[i]);
        DB.insert(TABLE_CONTACTS, null, cv);

    }

        cv.close();
        DB.close();
    }
catch(Exception ex){
    Log.e("Error in phone contact insertion", ex.toString());
}

edited Sep 2, 2016 at 12:04

answered Jul 27, 2016 at 6:57

MalhotraUrmil

861 silver badge10 bronze badges

Collectives™ on Stack Overflow

Passing an array of data into a SQLite Database in android

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related