Angular Interpolation Error when formatting number

Question

I'm fairly new to Angular and am probably missing something obvious but I have the following custom filter:

propertyApp.filter('telLink', function() {
return function(tel) {

    // To avoid interpolating error
    if(typeof(tel) != undefined) {

        // Remove any leading zeros
        if(tel.charAt(0) === '0') {
            tel = tel.substr(1);
        }

        tel = "44" + tel;

        // Remove any internal whiespace
        return tel.replace(" ", "");
    }
}

});

When I use this in a view I get this:

Can't interpolate: tel:{{property.agent_phone | telLink}}
TypeError: Cannot call method 'charAt' of undefined

Could someone point me in the right direction? Thanks in advance.

Dan · Accepted Answer · 2014-02-08 16:01:13Z

5

Instead of

if(typeof(tel) != undefined) {

just do

if (tel) {

This checks for "truthyness," and an undefined tel will not pass this test (the current code lets undefined values through)

js has lots of strange inconsistent behaviour. Here's the top link on google for truthyness : http://www.sitepoint.com/javascript-truthy-falsy/

answered Feb 8, 2014 at 16:01

Dan

3,2682 gold badges24 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Soviut Over a year ago

An even better way would be to use angular.isDefined(tel). It does mostly the same thing but guarantees the value is suitable for angular to consume.

Collectives™ on Stack Overflow

Angular Interpolation Error when formatting number

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related