HTML/PHP Form Problems

Question

I'm relatively new to web coding, but I know quite a bit, I was making a registration form earlier, which also checks if the fields are empty. It comes up OK, but nothing seems to work, when the fields are empty, the message doesn't come up, and when the fields are fine, it just loads but doesn't actually insert it into the database. Also, once I press the submit button, the form just disappears as well. Any help would be much appreciated.

<form method="post">
<?php
if(isset($_POST['submit'])){
    $username=$_POST['username'];
    $password=$_POST['password'];
    $password=md5(hash("sha512",$password));
    if(empty($username) or empty($password)){
        $message="Please enter information into the fields.";
    } else {
        mysql_query("INSERT INTO `users` VALUES('',$username,$password)");
        $message="Register successful!";
    }
    echo "<div id='box>$message</div>";
}
?>
Username: <input type="text" name="username" /><br>
Password: <input type="password" name="password" /><br>
<input type="submit" name="submit" value="Sign Up">
</form>

Stop using mysql_* functions, it will be deprecated soon. And you have to escape the inputs from the user's input. — kpmDev
– kpmDev, Commented Feb 22, 2014 at 18:26
read this: in2.php.net/manual/en/mysqli.real-escape-string.php — kpmDev
– kpmDev, Commented Feb 22, 2014 at 18:35
just change $username= mysql_real_escape_string($_POST['username']);$password=mysql_real_escape_string($_POST['password']); in2.php.net/mysql_escape_string But i suggest to use mysqli or PDO. — kpmDev
– kpmDev, Commented Feb 22, 2014 at 18:40

Community · Accepted Answer · 2023-11-17 19:59:20Z

2

It looks like you are not printing out mysql errors, you just need to add or die(mysql_error()); at the end of the query as in my example i did. Anyway you should surround your strings with quotes. The page came out blank when you press because if condition is met. So change as follow

mysql_query("INSERT INTO `users` VALUES('','$username','$password')") or die(mysql_error());

As side note i would stop using mysql_ function since they are derecated and use instead either PDO or mysqli with prepared statements to avoid any risk of mysql injections since your code is highly vulnerable. LEARN MORE HERE

As CodeBird correctly stated

md5 of an empty string will return a 32 chars string, so the password you are testing will never be empty

edited Nov 17, 2023 at 19:59

CommunityBot

11 silver badge

answered Feb 22, 2014 at 16:59

Fabio

23.5k12 gold badges57 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

CodeBird Over a year ago

You should add that md5 of an empty string, returns a 32 chars string, so actually the password he's testing is never empty

poseidon Over a year ago

Hi, I changed the query but I am getting the error of 'No Database Selected' - however, this is my connect code, what is wrong with it? $con = mysqli_connect("localhost","root","password","follow");

Fabio Over a year ago

So you are not connected to database, check this stackoverflow.com/questions/6326696/…

Fabio Over a year ago

So add the second part about mysql_select_db

rakeshjain · Accepted Answer · 2014-02-22 17:02:58Z

1

Change the query statement to

mysql_query("INSERT INTO `users` VALUES('','$username','$password')");

Start using mysqli_* functions instead of mysql_* as the latter are deprecated

answered Feb 22, 2014 at 17:02

rakeshjain

1,76111 silver badges11 bronze badges

Comments

Raviranjan Mishra · Accepted Answer · 2014-02-22 17:22:20Z

check this out "(`id`, `username`, `password`)" example column name use what you have made it.
<?php
if(isset($_POST['submit']))
{
    $username=$_POST['username'];
    $password=$_POST['password'];
    enter code here
    if(empty($username) || empty($password)){
        $message="Please enter information into the fields.";
    } else {
        $password=md5(hash("sha512",$password));
        mysql_query("INSERT INTO `users` (`id`, `username`, `password`) VALUES('','$username','$password');");
        $message="Register successful!";
    }
    echo "<div id='box'>".$message."</div>";
}
?>
<form method="post" action="">
    <input type="text" name="username" /><br>
    <input type="password" name="password" /><br>
    <input type="submit" name="submit" value="Sign Up">
</form>

Gus de Boer · Accepted Answer · 2014-02-22 16:59:22Z

0

Your insert query is wrong, use:

INSERT INTO tablename (col1, col2) VALUES('data1', 'data2' )

Or you can use

INSERT INTO tablename SET col1 = "data1", col2 = "data2"

answered Feb 22, 2014 at 16:59

Gus de Boer

40113 silver badges24 bronze badges

Comments

Community · Accepted Answer · 2023-11-17 20:33:26Z

0

You are having an issue because you are misusing empty()

A variable is considered empty if it does not exist or if its value equals FALSE

Also you should use double-pipes || for or in your if()

This:

if(empty($username) or empty($password)){

Should be:

if($username === '' || $password === ''){

edited Nov 17, 2023 at 20:33

CommunityBot

11 silver badge

answered Feb 22, 2014 at 17:01

MonkeyZeus

20.8k5 gold badges41 silver badges83 bronze badges

1 Comment

poseidon Over a year ago

Hi, I just did that, and tried it but as I said in the question, the area is going blank, so still no error message, is there any way to solve this?

Collectives™ on Stack Overflow

HTML/PHP Form Problems

5 Answers 5

4 Comments

Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related