Update filtered objects in array

Question

I have an array of objects. I want to filter them and then do something to the filtered objects. This is my attempt so far.

Positions Object

    function Position (title, type, purchasable){
    this.title = title;
    this.type = type;
    this.purchasable = purchasable || false;
}
function Purchasable (prices){
    this.owner = "unowned";
    this.rating = 0;
    this.prices = prices;
    this.price = this.prices[this.rating];
}
function City (title,set,prices){
    Position.call(this, title, "city", true);
    Purchasable.call(this, prices);
    this.set = set;
}
positions = [
    new City("Cairo", "brown", [60,2,10,30,90,160,250]),
    new City("Vienna", "brown", [60,4,20,60,180,320,450]),
    new City("Vienna", "blue", [60,4,20,60,180,320,450])
    ];
});

Function

function test() {
    var set = "brown";
    positions.filter(function(obj){
        obj.set === "brown"; //do something to every brown set, eg owner = me
    });
    //I want to change the values of the objs in positions array


}

I forgot to mention that I want to change the original obj and not create a new array — Elton
– Elton, Commented Feb 28, 2014 at 17:25

just somebody · Accepted Answer · 2014-02-28 17:20:57Z

3

var set = "brown"
var filtered = positions
  .filter(function (obj)
  {
    return obj.set === "brown"
  })
  .map(function (obj)
  {
    obj.owner = me
    return obj
  })
;
console.log(filtered);

edited Feb 28, 2014 at 17:20

answered Feb 28, 2014 at 17:14

just somebody

19.4k6 gold badges55 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

emanuel sanga Over a year ago

Considering you want only the filtered values, this is correct.... It misses its mark when you want all the remainders from the filter

just somebody Over a year ago

@emanuelsanga your definition of "filter" is incongruent with the generally accepted one.

emanuel sanga Over a year ago

anhaa, @justsomebody, semantics pal,, but i believe you got my point.... or is there something I missed there buddy?

Bobby · Accepted Answer · 2014-02-28 17:15:45Z

0

What about the jQuery .each() function ? https://api.jquery.com/each/

function test() {
    var set = "brown";
    var filtered = positions.filter(function(obj){
        obj.set === "brown"; //do something to every brown set, eg owner = me
    }).each(function(index, item){
         //do something with the object here; your objects are the item parameter

         obj.owner = "me";
    });

}

answered Feb 28, 2014 at 17:15

Bobby

3021 silver badge12 bronze badges

Comments

jCuga · Accepted Answer · 2014-02-28 17:49:54Z

0

You need your filter callback to return true/false. You want to return true when the current item should be included in the resulting array and false if it should be excluded. So if you want to filter where obj.set === "brown", do:

var filtered = positions.filter(function(obj){
    if (obj.set === "brown") {
        obj.owner = "me";  // your additional action to perform
        return true;
    }
    return false;
});

As 'just somebody' notes in the comments, It is generally bad practice to make filter do anything other than the filtering part. But this above example shows you how to do this inside of the filter per your original question.

edited Feb 28, 2014 at 17:49

answered Feb 28, 2014 at 17:07

jCuga

1,5534 gold badges16 silver badges28 bronze badges

1 Comment

just somebody Over a year ago

actually, filter is nice because it does (by name) just one thing. you should leave the // do something for a another pass through the filtered array with .map. .filter(function (o) { return o.set == 'brown' }).map(function (o) { mangle(o) })

Collectives™ on Stack Overflow

Update filtered objects in array

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related