Javascript: Function within a function

Question

Is there any reason why this code isn't working? I have put the entire script into a function for the sake of the playAgain variable (see bottom) which would restart the function. Any help would be much appreciated.

function headsTails() {
    var userChoice;
    userChoice = prompt('Heads or Tails');

    function myGame(heads,tails) {  
        var result;
        var coin;
        result = Math.random()
        if(result > 0.5) {
            coin = "heads";
        } else {
            coin = "tails";
        }
        if(userChoice === "heads") {
            if(coin = "heads") {
                alert("You win!");
            } else if(coin = "tails") {
                alert("You lose!");
            }
        }
        if(userChoice === "tails") {
            if(coin = "heads") {
                alert("You lose!");
            } else if(coin = "tails") {
                alert("You win!");
            }
        }
    }
    myGame();
    var playAgain;
    playAgain = confirm(Do you want to play again?)
    if(playAgain) {
        headsTails();
    } else {
        alert("Thanks for playing!")
    }
}

In what way is this not working? Also, "Sorry about the messy spacing" -- really? Just fix it! It would make it less likely that someone capable of answering would simply move on without bothering. — Ted Hopp
– Ted Hopp, Commented Mar 12, 2014 at 22:01
Shouldn't confirm(Do you want to play again?) be confirm('Do you want to play again?')? — DarkAjax
– DarkAjax, Commented Mar 12, 2014 at 22:02
Formatting is important because it can help you realize why your code might not be working. Check it again after the reformatting and see if you can tell why it might not be doing what you expect. — kinakuta
– kinakuta, Commented Mar 12, 2014 at 22:05
In regards to spacing/formatting, jsbeautifier.org is great for formatting code before posting — Ian
– Ian, Commented Mar 12, 2014 at 22:08
I'm confused that you are using === in the conditions, immediately followed by = in the next condition. — Felix Kling
– Felix Kling, Commented Mar 12, 2014 at 22:21

JohnJohnGa · Accepted Answer · 2014-03-12 22:06:01Z

1

You have many syntax errors:

coin = "heads" -> coin === "heads"
coin = "tails" -> coin === "tails"
confirm(Do you want to play again ?) -> confirm("Do you want to play again ?")

I would recommend reading about Javascript and in general about programming languages...

Corrected headsTails function:

function headsTails() {
    var userChoice;
    userChoice = prompt('Heads or Tails');

    function myGame(heads, tails) {
        var result;
        var coin;
        result = Math.random();
        if (result > 0.5) {
            coin = "heads";
        } else {
            coin = "tails";
        }
        if (userChoice === "heads") {
            if (coin === "heads") {
                alert("You win!");
            } else if (coin === "tails") {
                alert("You lose!");
            }
        }
        if (userChoice === "tails") {
            if (coin === "heads") {
                alert("You lose!");
            } else if (coin === "tails") {
                alert("You win!");
            }
        }
    }

    myGame();
    var playAgain;
    playAgain = confirm("Do you want to play again ?")
    if (playAgain) {
        headsTails();
    } else {
        alert("Thanks for playing!")
    }
}

answered Mar 12, 2014 at 22:06

JohnJohnGa

15.7k20 gold badges65 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gilbert-v Over a year ago

Thank you, this has solved all of my problems concerning the subject.

Collectives™ on Stack Overflow

Javascript: Function within a function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related