can't add getted elements from sql query to array

Question

function get_comment_count_for_events() {
    $query = "SELECT event_token , COUNT(NULLIF(event_token, '')) AS counts FROM comment GROUP BY event_token ORDER BY counts DESC;";

    $result = mysql_query($query);
    $comment_count = array();
    while ($row = mysql_fetch_array($query)) {
        $comment_count = $row;
    }
    if (!$result) {
        trigger_error('Invalid query: ' . mysql_error() . " in " . $query);
    }
    return $comment_count;
}

This is my function.

I use it from other file

foreach (get_comment_count_for_events() as $comment_count_event) {
    echo $comment_count_event['tiken_event'];
    echo $comment_count_event['count'];
}

But in databese when i test query it's work: result: event_token - counts

1 - 13

2 - 13

8 - 11

3 - 8

5 - 7

7 - 4

6 - 3

''- 0

Hüseyin BABAL · Accepted Answer · 2014-03-26 13:09:10Z

1

Update your code, you are overriding your $comment_count variable. You need to use array instead;

while ($row = mysql_fetch_array($result)) {
    $comment_count[] = $row;
}

Also in your second iteration ,field names are incorrect. Update them also;

foreach (get_comment_count_for_events() as $comment_count_event) {
    echo $comment_count_event['event_token'];
    echo $comment_count_event['counts'];
}

edited Mar 26, 2014 at 13:09

answered Mar 26, 2014 at 12:08

Hüseyin BABAL

15.6k5 gold badges53 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2022879 Over a year ago

while ($row = mysql_fetch_array(-----my mistake----$result------)) {

Collectives™ on Stack Overflow

can't add getted elements from sql query to array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related