Error in IF statement powershell

Question

I think there's a problem with this if statement.

Function Get-IsFirewallProfileEnabled([string]$profile)
{
    Return [bool](Get-NetFirewallProfile -name "Domain" | Where Enabled -eq "False")
}


# If the firewall for some of the 3 profiles is not enabled
if ( ((Get-IsFirewallProfileEnabled("Domain")) -or (Get-IsFirewallProfileEnabled("Private")) -or (Get-IsFirewallProfileEnabled("Public"))) -eq "False")
{
    Write-Output "Enabling..."
    # Enable Windows firewall for for all (the 3 profiles)
    Set-NetFirewallProfile -Profile Domain,Private,Public -Enabled True
}

Whether I have activated a firewall or not, this script always does nothing. What's happening?

SOLUTION

# Now this function is dynamic
Function Get-IsFirewallProfileEnabled([string]$profile)
{
    Return [bool](Get-NetFirewallProfile -name $profile | Where Enabled -eq "True")
}


# If the firewall for some of the 3 profiles is not enabled
if ( -not(Get-IsFirewallProfileEnabled("Domain")) -or -not(Get-IsFirewallProfileEnabled("Private")) -or -not(Get-IsFirewallProfileEnabled("Public")) )
{
    Write-Output "Enabling..."
    # Enable Windows firewall for for all (the 3 profiles)
    Set-NetFirewallProfile -Profile Domain,Private,Public -Enabled True
}

Kohlbrr · Accepted Answer · 2014-04-02 02:57:02Z

2

As Robert mentioned, you are using the string False, not the Boolean $false in your if statement.

But the logic in your if statement isn't working as expected:

if(((Boolean) -or (Boolean) -or (Boolean)) -eq $false)

will not produce the desired result in Powershell (it will only execute if all of the values are $false). Since if always executes on $true, you can achieve desired results by simply -not-ing the values from Get-IsFirewallProfileEnabled like so:

if((-not(Get-IsFirewallProfileEnabled("Domain")) -or (-not(Get-IsFirewallProfileEnabled("Private")) -or (-not(Get-IsFirewallProfileEnabled("Public")))

This will execute the if block when any of the values are $false.

edited Apr 2, 2014 at 2:57

answered Apr 2, 2014 at 2:51

Kohlbrr

4,1391 gold badge23 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3270009 Over a year ago

Yes, this better IF statement didn't work before, so I programmed this worse IF, haha, thx.

Robert Groves · Accepted Answer · 2014-04-02 02:42:27Z

1

You want to use $false not "False".

"False" is a string literal and will never match if the boolean value returned by the condition ((Get-IsFirewallProfileEnabled("Domain")) -or (Get-IsFirewallProfileEnabled("Private")) -or (Get-IsFirewallProfileEnabled("Public"))) is false.

For example:

if ("False") { write-host "true" }

The line above will always write "true" to the host. This is because a non-empty string literal equates to $true.

The line below will never write "true" to the host.

if ($false) { write-host "yes" }

edited Apr 2, 2014 at 2:42

answered Apr 2, 2014 at 2:37

Robert Groves

7,7586 gold badges40 silver badges50 bronze badges

Collectives™ on Stack Overflow

Error in IF statement powershell

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related