Counter not working on javascript

Question

im having a problem with an accumulator on Javascript, im new onto this, so could anybody help me with this? i just want an accumulator for right answers this is my script because it just keeps giving me 0 as a result.

<script type="application/javascript">
 var count=0;
function counter(){
    count=count+1;
}
function results(){
alert ("The number of correct answers is "+count)   
}
</script>

and this is the structure for my buttons

<input type="radio" name="p1" value="answ" onsubmit="counter()">

for correct answer

<input type="radio" name="p1" value="answ1">

for other options

Hello! Don't forget to accept an answer, you even get 2 rep for it! — SomeKittens
– SomeKittens, Commented Apr 4, 2014 at 21:13

SomeKittens · Accepted Answer · 2014-04-04 04:11:26Z

1

The onsubmit event only works for form elements. You're thinking of onclick. However, it's better to have event listeners.

HTML:

<button id="increment">Click Me</button>
The counter is at <span id="counter">0</span>

JS:

var btn = document.querySelector('#increment');
var ctr = document.querySelector('#counter');
var counter = 0;
var increment = function() {
    counter++;
    ctr.textContent = counter;
};

btn.addEventListener('click', increment);

Here's a JSFiddle to play with

edited Apr 4, 2014 at 4:11

answered Apr 4, 2014 at 2:02

SomeKittens

39.6k19 gold badges117 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3496155 Over a year ago

Im using the "onclick" on my submit button being the code this one : <input type="submit" value="Submit" onclick="results()" then is there anyway i could trigger the counter from the "radio forms"?

SomeKittens Over a year ago

@user3496155 I've updated the question with some code. Does that help explain it?

Cyassin · Accepted Answer · 2014-04-04 02:08:09Z

0

onsubmit would not be triggering the counter() function. I dont think onsubmit can be used on a radio button, and even so clicking it would be not triggering the onsubmit, it would trigger the onclick.

Because counter() is never being executed, the count never increases.

Also make sure your order of events is correct so that counter() will always trigger before results() as I can not see where results() is called in your code.

answered Apr 4, 2014 at 2:08

Cyassin

1,5001 gold badge15 silver badges32 bronze badges

1 Comment

user3496155 Over a year ago

Im sorry i forgot to put that. im calling results in the submit button <input type="submit" value="Submit" onclick="results()"

Collectives™ on Stack Overflow

Counter not working on javascript

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related