Using Javascript to Replace Link

Question

I'm using this Javascript code in an attempt to replace the links on a page with a message that says "DOWNLOAD", with a hyperlink that leads to my registration page.

The problem is the "DOWNLOAD" text is not replacing the original link text. The original link is displayed. It does lead to the registration page, but again, the original link on the page is still visible as text.

Any ideas?

<script>
    function replaceLinks() {
        var links = document.getElementsByTagName('a');
        for (var i = 0; i < links.length; i++) {
            links[i].innerHtml = 'DOWNLOAD' + 
                    '<a href="register.php">register here</a>.';
            links[i].href = 'register.php';
        }
    }
</script>

You're putting a link inside another link. I don't think that will work. — Barmar
– Barmar, Commented Apr 10, 2014 at 3:54

Barmar · Accepted Answer · 2014-04-10 03:58:46Z

1

It should be:

function replaceLinks() {
    var links = document.getElementsByTagName('a');
    for (var i = 0; i < links.length; i++) {
        links[i].innerHTML = 'DOWNLOAD register here.';
        links[i].href = 'register.php';
    }
}

The property is innerHTML, the last part is all uppercase. And you don't need to nest another link inside the link.

answered Apr 10, 2014 at 3:58

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MShah · Accepted Answer · 2014-04-10 04:02:18Z

1

It looks like you have a capitalization issue - it should be innerHTML. You can also remove other parts of your code:

function replaceLinks() {
var links = document.getElementsByTagName('a');

for (var i = 0; i < links.length; i++) {
    console.log(links);
    links[i].innerHTML = 'DOWNLOAD';
    links[i].href = 'register.php';
    }
};

answered Apr 10, 2014 at 4:02

MShah

3061 silver badge6 bronze badges

Comments

Kyoungwon Lee · Accepted Answer · 2014-04-10 04:14:10Z

0

In jQuery way,

function replaceLinks() {
    var links = $('a');
    for (var i = 0; i < links.length; i++) {
        links[i].html('DOWNLOAD register here.');
        links[i].attr('href') = 'register.php';
    }
}

answered Apr 10, 2014 at 4:14

Kyoungwon Lee

1391 gold badge1 silver badge7 bronze badges

Collectives™ on Stack Overflow

Using Javascript to Replace Link

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related