Error while updating document using $setOnInsert - mongoDB

Question

I had updated the mongoDB using $setOnInsert. It is working in 2.4 version of mongoDB but it is throwing error in 2.6 version.

Following are the code

   BasicDBObject update = new BasicDBObject();
   BasicDBObject visits = new BasicDBObject();
   visits.append("request", getRequestInfo(input));//Some documents
   update.append("$setOnInsert", {}).append("$push", visits);
   collection.update(searchQuery, update, true, false);

Error

  java.lang.RuntimeException: com.mongodb.MongoException: '$setOnInsert' is empty. You must specify a field like so: {$mod: {: ...}}

Note: I had two mongoDB servers. It is working in one server. It is giving above issue in another. Only difference is version.

After Updating the document in 2.4.8

   {
     "_id" : ObjectId("536113766a47069648b4695d"),
     "request" : [
            {
              "currentVisit" : "1398254762",
              "lastVisit" : "1398254762"
            }
      ],
     "session" : "1",
     "uuid" : "113862726056042"
    }

Any problem with the version.

Any suggestion will be grateful.

Very odd. So what exactly was happening before the upgrade. Can you please add that to your question? — Neil Lunn
– Neil Lunn, Commented May 1, 2014 at 11:35
2.4 allowed for empty operator values? Sounds like a bug that was secretly fixed, has happened before — Sammaye
– Sammaye, Commented May 1, 2014 at 11:37
Agreed. Seems like the application had a bug that was ignored by MongoDB until now. — Gimby
– Gimby, Commented May 1, 2014 at 11:38
Sounds buggy. Is the only change the server version, or have you changed driver as well? — Neil Lunn
– Neil Lunn, Commented May 1, 2014 at 11:40

Sammaye · Accepted Answer · 2014-05-01 12:28:59Z

2

This is the issue you are relating to: https://jira.mongodb.org/browse/SERVER-12266 which applies since 2.5.4.

It seems this behaviour is unlikely to change due to this issue being marked as "works as designed".

The last comment being:

I spoke to Scott Hernandez about this today, and he explained the new strictness around empty modifiers is intended to alert users that were inadvertently sending over empty updates.

Instead you should have your code to put:

append("$setOnInsert", {}).

Into an if statement to detect its setting.

answered May 1, 2014 at 12:28

Sammaye

44k7 gold badges110 silver badges149 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Neil Lunn · Accepted Answer · 2014-05-01 12:08:33Z

2

So the syntax here is well, intriguing at best. But I'd call it an edge case and not really how you should have been invoking this. The better version would be:

   BasicDBObject update = new BasicDBObject();
   BasicDBObject visits = new BasicDBObject();
   visits.append("request", getRequestInfo(input));//Some documents
   update.append("$setOnInsert", new BasicDBObject("$push", visits));
   collection.update(searchQuery, update, true, false);

Which I'm pretty sure is not going to cause an error.

P.S : A very interesting structure to have this as an array. So you can comment if there was a reason, but it would seemingly be a case that $setOnInsert may not actually be required and you could just possibly leave the standard $push operation in the update, that is unless you really mean to only ever have one array element there.

answered May 1, 2014 at 12:08

Neil Lunn

151k36 gold badges356 silver badges327 bronze badges

1 Comment

karthick Over a year ago

Thanks. I am getting the following error java.lang.RuntimeException: com.mongodb.MongoException: The dollar ($) prefixed field '$push' in '$push' is not valid for storage.

Collectives™ on Stack Overflow

Error while updating document using $setOnInsert - mongoDB

Following are the code

Error

After Updating the document in 2.4.8

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Following are the code

Error

After Updating the document in 2.4.8

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related