SQL Inserting Syntax Error

Question

Hey Guys I'm getting a syntax error with my SQL on my PHP page.

Basically what my page does is that it simply inserts data from a form and inserts into the database.

This is my code and my error:

Problem with query.

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '', '', '', '', '', '')' at line 2

$sql = "INSERT INTO user (username, password, gname, mname, surname, address, state, postcode, tel)
VALUES ( '$usernamestr', '$passwordstr','$firstnamestr', '$middlenamestr’, '$familynamestr', '$addressstr', '$statestr', '$postcodestr', '$phonestr');";
$rs = mysql_query($sql, $conn)
or die ('Problem with query' . mysql_error());

I thought this was the way to do it? which is absolutely weird.

xkcd.com/327 -- Learn about PDO and all your problems will be solved. — Niet the Dark Absol
– Niet the Dark Absol, Commented May 28, 2014 at 14:56
Clearly the variables don't have the expected values, which is great, because it's preventing passwords from being stored as plaintext. — nthall
– nthall, Commented May 28, 2014 at 14:56
Side note: You should escape the variables, before using them in the query. de1.php.net/mysql_real_escape_string or if you choose MYSQLi de1.php.net/manual/en/mysqli.real-escape-string.php — Alex2php
– Alex2php, Commented May 28, 2014 at 14:59

John Conde · Accepted Answer · 2014-05-28 14:56:48Z

10

You have a funky quote:

VALUES ( '$usernamestr', '$passwordstr','$firstnamestr', '$middlenamestr’, '$familynamestr', 
                                                                       ^^^^
                                                                       HERE

It is a ’ and needs to be a ' (as the syntax highlighter shows in my answer but not in your question).

answered May 28, 2014 at 14:56

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

InsignificantPuppet Over a year ago

Thanks dude, I really cant believe i missed that. Looked exactly like a single quote to me.

John Conde Over a year ago

I had to re-read it several times to spot it as it definitely does not stand out. If your query wasn't otherwise correct I wouldn't have looked at it quite so hard.

Collectives™ on Stack Overflow

SQL Inserting Syntax Error

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related