Javascript syntax error - missing )

Question

I keep getting an error in Firebug regarding the onClick event.

I've tried various different combinations of " and ' but to no avail. This worked fine before the onClick event was added.

Can anybody spot what I might be doing wrong?

addPhoneLogo: function (n) {
    if (i.phoneLogoLink.length > 1) var t = e('<span style="position:absolute; top:10px; right:10px;"><a onclick="ga('
    send ', '
    event ', '
    Call tracking ', '
    Click to call ', '
    Menufication ');"  href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    else var t = e('<span style="position:absolute; top:10px; right:10px;"><a href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    n.append(t)
},

Bhushan Kawadkar · Accepted Answer · 2014-07-10 10:35:10Z

1

Use escape character to add single quotes for onclick parameters : Use \' instead of '

addPhoneLogo: function(n) {
             if (i.phoneLogoLink.length > 1) var t = e('<span style="position:absolute; top:10px; right:10px;"><a onclick="ga(\'send\', \'event\', \'Call tracking\', \'Click to call\', \'Menufication\');"  href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
             else var t = e('<span style="position:absolute; top:10px; right:10px;"><a href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
             n.append(t)
         },

answered Jul 10, 2014 at 10:35

Bhushan Kawadkar

28.6k5 gold badges39 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Anoop Joshi P · Accepted Answer · 2014-07-10 10:35:15Z

1

Escape the ' by using \

addPhoneLogo: function (n) {
    if (i.phoneLogoLink.length > 1)
        var t = e('<span style="position:absolute; top:10px; right:10px;"><a onclick="ga(\'send \', \'event\',\'       Call tracking \', \'Click to call \', \'Menufication \');"  href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    else
        var t = e('<span style="position:absolute; top:10px; right:10px;"><a href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    n.append(t)
},

answered Jul 10, 2014 at 10:35

Anoop Joshi P

25.6k9 gold badges35 silver badges54 bronze badges

Comments

Imnotapotato · Accepted Answer · 2014-07-10 10:37:22Z

0

addPhoneLogo: function (n) {
    if (i.phoneLogoLink.length > 1)
        var t = e('<span style="position:absolute; top:10px; right:10px;"><a onclick="ga(\'send \', \'event\',\'       Call tracking \', \'Click to call \', \'Menufication \');"  href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    else
        var t = e('<span style="position:absolute; top:10px; right:10px;"><a href="' + phoneNum + '"><img src="' + i.phoneLogo + '" id="menufication-phone-logo" /></a></span>');
    n.append(t)
},

answered Jul 10, 2014 at 10:37

Imnotapotato

5,99814 gold badges91 silver badges159 bronze badges

Collectives™ on Stack Overflow

Javascript syntax error - missing )

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related