AngularJS: Pushing to array does not work

Question

I have an empty array that I'm just pushing integers into. However, the console.logs print am empty array [ ] everytime I trigger this function in my view:

html:

<div ng-repeat="color in colors">
  {{color.name}} <input type="checkbox" ng-model="color_ids" ng-change="toggleColorFilter(color.id)">
</div>

angular:

app.controller('IndexCtrl', ['$scope', "Product", "Color", function($scope, Product, Color) {

  ...
  $scope.color_ids = [];


  $scope.toggleColorFilter = function(color_id) {
    var index = $scope.color_ids.indexOf(color_id);
    if (index > -1) {
      $scope.color_ids.push(color_id);
    } else {
      $scope.color_ids.splice(index, 1);
    }
    console.log($scope.color_ids);
  };


}]);

tymeJV · Accepted Answer · 2014-07-23 21:14:01Z

1

Your if logic is backwards - it's saying that if the color id exists - then push it, else, splice a non-existent value...flip the logic:

if (index > -1) {
  $scope.color_ids.splice(index, 1);
} else {
  $scope.color_ids.push(color_id);
}

answered Jul 23, 2014 at 21:14

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

bigpotato Over a year ago

It worked!! but why? If the index is -1 that means it exists in the array??

tymeJV Over a year ago

If the index is greater than -1 - it exists - so you want to splice it. If the index equals -1 it doesnt exist.

bigpotato Over a year ago

... how did I miss that. I need to step away from the computer for a few minutes. thanks!!

Collectives™ on Stack Overflow

AngularJS: Pushing to array does not work

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related