parse error in log in php

Question

I am building a site which has a user database where the users can log in and sign up. When I test the PHP code for login, it says “parse error” once and invalid { in line 16. What is worng in my code?

<?php

$user = $_REQUEST['user'];
$pass = $_REQUEST['pass'];
$con = mysql_connect("localhost","root","xxxxxxxxxx") or die('Could not connect:'.mysql_error());
$test = mysql_select_db("users",$con)or die("unable to connect");

$result = "SELECT  * FROM users where username='$user' AND password='$pass'";
$alpha = @mysql_query($result,$con);

if($alpha==1)
{
     $expire=time()+60*60*24*30;
     setcookie("id",$row['id'],$expire);
     echo "Logged in. as <b>".$row['username']."</b>";
     $userID = $row['id'];
     header("index map.html")
 }
 else
 {
     echo "<b>Username or password  is wrong</b><br><br>";
     header("index.html")
 }

 mysql_close($con);

 ?>

mysql is deprecated use MYSQLi

Faiz Ahmed
– Faiz Ahmed

2014-08-04 08:44:25 +00:00
Commented Aug 4, 2014 at 8:44 — Faiz Ahmed
– Faiz Ahmed, Commented Aug 4, 2014 at 8:44

DannyTheDev · Accepted Answer · 2014-08-04 08:45:17Z

1

There are a couple of issues with your PHP here.

header needs a semi-colon closing it
header needs a location set.. i.e header('location: index.html');

you should replace

header("index map.html")

with

header("location: map.html");

Also you need to replace

header("index.html")

with

header("Location: index.html");

answered Aug 4, 2014 at 8:45

DannyTheDev

4,1732 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Daniel Wondyifraw · Accepted Answer · 2014-08-04 09:05:48Z

0

What the hell ? Where is row comes from ? you didnt call any mysql_fecth_array or some thing related to traverse the result int a row .. at least u code have used

$row = mysql_fetch_result/array($result,$conn);

then use row as my suggestion ...

if($alpha==1)
{
     $expire=time()+60*60*24*30;
     setcookie("id",$row['id'],$expire);
     echo "Logged in. as <b>".$row['username']."</b>";
     $userID = $row['id'];
     header("index map.html")
 }

answered Aug 4, 2014 at 9:05

Daniel Wondyifraw

7,7338 gold badges62 silver badges82 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:20:50Z

-1

first of all your code is very unsecure ! We can easily do some SQL Injection. Try to use at least: mysql_real_escape. (How to use mysql_real_escape_string function in PHP). Also using PDO will be better (in my point of view).

The you forgot the dots in

$result = "SELECT * FROM users WHERE username='.$user.' AND password='.$pass.'"; (line 7)

And you forgot to put the semi-colons and the field keyname (line 21) should be header("location: index.html");

Best regards.

edited May 23, 2017 at 12:20

CommunityBot

11 silver badge

answered Aug 4, 2014 at 8:48

Yves Lange

4,0143 gold badges25 silver badges35 bronze badges

Comments

Satish Sharma · Accepted Answer · 2014-08-04 08:53:11Z

-2

your header() function is calling incorrectly correct it with

header("location:index-map.html");

edited Aug 4, 2014 at 8:53

answered Aug 4, 2014 at 8:44

Satish Sharma

9,6356 gold badges31 silver badges52 bronze badges

2 Comments

DannyTheDev Over a year ago

what is header('index supposed to do?

Faiz Ahmed Over a year ago

there's no header called index.

Collectives™ on Stack Overflow

parse error in log in php

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related