NullPointerException on array with length one initializing

Question

This is my method to updateHighScoreRecords():

    public GameRecord[] updateHighScoreRecords(GameRecord[] highScoreRecords, String name, int level, int score) {
    GameRecord[] gameRecord = null;

    if (highScoreRecords.length == 0) {     // Rule one
        gameRecord = new GameRecord[1];
        gameRecord[0].setName(name);
        gameRecord[0].setLevel(level);
        gameRecord[0].setScore(score);
        System.out.println("Role one Done");
    }
    return gameRecord;
}

And this is my GameRecord class:

public class GameRecord {
private String name;
private int level;
private int score;

public GameRecord(String name, int level, int score) {

    this.name = name;
    this.level = level;
    this.score = score;
}
public String getName() {
    return name;
}

public void setName(String name) {
    this.name = name;
}
public int getLevel() {
    return level;
}
public void setLevel(int level) {
    this.level = level;
}

public int getScore() {
    return score;
}

public void setScore(int score) {
    this.score = score;
}
}

But there is a nullPointer exception on this line:

gameRecord[0].setName(name);

Why?

I want to return an array of GameRecord type when highScoreRecords length is zero.

Common Java rookie mistake: Instantiating an array does not instantiate the elements. — Ian McLaird
– Ian McLaird, Commented Aug 7, 2014 at 13:03
possible duplicate of What is a Null Pointer Exception, and how do I fix it? — DavidPostill
– DavidPostill, Commented Aug 7, 2014 at 13:04

Suresh Atta · Accepted Answer · 2014-08-07 13:06:02Z

4

You never initialized zeroth element. First you have to add element at zero position and then access it.

 gameRecord[0] = new GameRecord();
 gameRecord[0].setName(name);

When you wrote

  gameRecord = new GameRecord[1];

That means you are just initializing an array to store 2 GameRecord elements. Nothing else. Initially those are null's. You need to initialize each element to use them further. Otherwise they are still null.

edited Aug 7, 2014 at 13:06

answered Aug 7, 2014 at 13:00

Suresh Atta

122k38 gold badges206 silver badges315 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

NullPointerException on array with length one initializing

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related