Angular promise after calling a service with $http

Question

I m actually developping an application with angularjs, and I m facing a problem with $http, and the result of an asynchronous service request to my webservice.

Actually, I m using this code :

var promise = undefined;

    UserService.getAll = function (callback) {

        promise = $http({
            url: __ADRS_SRV__ + "users",
            method: "GET",
            isArray: true
        }).success(function(data){
            return data;
        }).error(function(data){
            return $q.reject(data);
        });

        return promise;
    }

This doesnt work, and give me some stuff like, I dont know why :

Angular error returned by the call To know : in my controller, I want to use a really simple syntax like

var data = UserService.getAll();

Do you have any idea how should I process to access my data correctly ?

Thanks for advance

This looks like a job for $resource rather than $http. Additionally, you need to have a look at callbacks in Javascript because you're not returning what you think you are returning from inside the success/error functions — CodingIntrigue
– CodingIntrigue, Commented Aug 20, 2014 at 11:17

Julian Hollmann · Accepted Answer · 2014-08-20 11:31:18Z

2

you get the promise in return. There are multiple ways to use this promise.

Example 1 (Use promise in service and return reference of an object):

UserService.getAll = function () {  
    var dataWrapper = {
        myData: {},
        error: null
    };

    $http({
        url: __ADRS_SRV__ + "users",
        method: "GET",
        isArray: true
    }).success(function(data){
        dataWrapper.myData = data;
    }).error(function(data){
        dataWrapper.error = true;
        return $q.reject(data);
    });

    return dataWrapper;
}

Example 2 (Return promise and use it directly in the controller):

// service
UserService.getAll = function () {
    return $http({
        url: __ADRS_SRV__ + "users",
        method: "GET",
        isArray: true
    });
}
// controller
var promise = UserService.getAll();
promise.success(function(data) {
    $scope.data = data;
});

Example 3 (Use regular callback):

// service
UserService.getAll = function (cb) {
    $http({
        url: __ADRS_SRV__ + "users",
        method: "GET",
        isArray: true
    }).success(cb);
}
// controller
UserService.getAll(function(data) {
    $scope.data = data;
});

answered Aug 20, 2014 at 11:31

Julian Hollmann

2,9122 gold badges28 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

mfrachet Over a year ago

I ve only tried the last one actually, and it doesn't work because of $scope not accessible in the service

Julian Hollmann Over a year ago

There are comments to state that this is a part of code in the controller.

mfrachet Over a year ago

I know that, but the callback will be executed with the service context. And in the service, we dont have $scope defined, so it causes an error "undefined is not a function" :/

Julian Hollmann Over a year ago

The callback will be called in the promise context, yes. But you get $scope through the closure. Just be sure that you inject $scope into your controller.

fdreger · Accepted Answer · 2014-08-20 11:15:52Z

1

The "stuff" you mention is the very promise you create and return.

answered Aug 20, 2014 at 11:15

fdreger

12.6k1 gold badge38 silver badges46 bronze badges

4 Comments

mfrachet Over a year ago

So how can I access the data ? :-/

fdreger Over a year ago

the way you do it. In the callback function.

mfrachet Over a year ago

And in my controller ?

fdreger Over a year ago

the callback function might be defined in the controller. But you can't have asynchrony without callbacks, and $http is asynchronous.

Collectives™ on Stack Overflow

Angular promise after calling a service with $http

2 Answers 2

4 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related