Angular nesting same controller

Question

Hi is it a good practice to have controller within a controller in angular?

For Example:

The body tag of my html has a controller called "CommonCtrl" within the html tag i'm loading a template using includes and inside the template i reuse the same controller.

Code:

Index.html

<body ng-controller="commonCtrl as vm">

 <header data-ng-include="'app/includes/header.html'"></header>

  <div ng-show="vm.showThisdiv">show this div</div>
</body>

header.html

<header id="header" ng-controller="commonCtrl as vm">
<span ng-show="vm.displayRegisterHeader" id="extr-page-header-space"> <span class="hidden-mobile">Already registered?</span> <a href="#/login" class="btn btn-danger">Sign In</a> </span>
    <span ng-show="vm.displayLoginHeader" id="extr-page-header-space"> <span class="hidden-mobile">Need an account?</span> <a href="#/register" class="btn btn-danger">Create account</a> </span>
</header>

Satpal · Accepted Answer · 2014-09-01 11:43:01Z

1

You don't need to use ngController in header.html, Just remove the following line from header.html

<header id="header" ng-controller="commonCtrl as vm">

answered Sep 1, 2014 at 11:43

Satpal

134k13 gold badges168 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Angular nesting same controller

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related