I'm adding only the last element to the JS array

Question

Here is my code so far: I am trying to create a new JSON object called dataJSON using properties from the GAJSON object. However, when I try to iterate over the GAJSOn object, I get only its last element to be added to the array.

 var GAstring ='{"data":[{"bounceRate": "4","country":"Denmark"},{"bounceRate":
 "3","country":"Spain"},{"bounceRate":"6","country":"Romania"},
 {"bounceRate":"1","country":"Bulgaria"},{"bounceRate":"0","country":"Lithuania"},  
 {"bounceRate":"2","country":"Norway"}]}';
 var GAJSON=JSON.parse(GAstring);
 var viewJSON = {
    data:[]
 };
 var dataJSON ={};
 for(var i =0; i<GAJSON.data.length; i++) {
     dataJSON["bounceRate"] = GAJSON.data[i].bounceRate;
     dataJSON["country"] = GAJSON.data[i].country;
 }
 viewJSON.data.push(dataJSON);

Sure. You keep writing to the same properties of the dataJSON object over and over. What result were you expecting? — cookie monster
– cookie monster, Commented Sep 11, 2014 at 10:31
If you wanted an Array of objects, then create a new object inside the loop, and also .push() it inside the loop. — cookie monster
– cookie monster, Commented Sep 11, 2014 at 10:33

Andy · Accepted Answer · 2014-09-11 10:39:07Z

2

Your push of the new object should be within the loop.

 for(var i =0; i<GAJSON.data.length; i++) {
   viewJSON.data.push({
     bounceRate: GAJSON.data[i].bounceRate,
     country: GAJSON.data[i].country
   });
 }

DEMO

answered Sep 11, 2014 at 10:39

Andy

63.6k13 gold badges72 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Manwal · Accepted Answer · 2014-09-11 10:33:49Z

1

You are overwriting values every time at dataJSON["bounceRate"] = GAJSON.data[i].bounceRate;

Try this code:

var GAstring ='{"data":[{"bounceRate": "4","country":"Denmark"},{"bounceRate":"3","country":"Spain"},{"bounceRate":"6","country":"Romania"},     {"bounceRate":"1","country":"Bulgaria"},{"bounceRate":"0","country":"Lithuania"},     {"bounceRate":"2","country":"Norway"}]}';
 var GAJSON=JSON.parse(GAstring);
 var viewJSON = {
    data:[]
 };
 var dataJSON ={};
 for(var i =0; i<GAJSON.data.length; i++) {
     dataJSON[i] = [];
     dataJSON[i]["bounceRate"] = GAJSON.data[i].bounceRate;
     dataJSON[i]["country"] = GAJSON.data[i].country;
 }
 viewJSON.data.push(dataJSON);
console.log(viewJSON);

DEMO

answered Sep 11, 2014 at 10:33

Manwal

23.9k15 gold badges65 silver badges95 bronze badges

2 Comments

Andy Over a year ago

Why are you creating an array within an object within an array? Your code makes no sense - that's why you're downvoted.

Manwal Over a year ago

@andy you are correct. But i was pointing error of OP. Your solution is best then me. +1 for this.

Collectives™ on Stack Overflow

I'm adding only the last element to the JS array

2 Answers 2

Comments

DEMO

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related