Looping through a string of numbers in Javascript

Question

Hey guys working on a problem from CoderBytes. The directions of the following:

Using the JavaScript language, have the function DashInsert(num) insert dashes ('-') between each two odd numbers in num. For example: if num is 454793 the output should be 4547-9-3. Don't count zero as an odd number.

Use the Parameter Testing feature in the box below to test your code with different arguments.

So I didn't create a function but here is my road map.

num = 3333333333
arr = num.toString().split("")
for(var i = 0; i < arr.length; i++){
    if(arr[i] % 2 === 1 && arr[i + 1] % 2 === 1){
        num.toString().replace(arr[i].toString() + arr[i+1].toString(),
                    arr[i].toString() + "-" + arr[i+1].toString())
    }

    }

The thing is when I run this it only puts a dash between the first two threes. I really can't figure out why this is happening. Anyone know where I am going wrong?

semi-colons (;) are your friend!

jasonscript
– jasonscript

2014-09-22 05:47:14 +00:00
Commented Sep 22, 2014 at 5:47 — jasonscript
– jasonscript, Commented Sep 22, 2014 at 5:47

Abdul Jabbar · Accepted Answer · 2014-09-22 05:06:54Z

3

Here, this simple solution should do well:

var num = 3434333333
var arr = num.toString().split("");
var finalStr = "";
for(var i = 0; i < arr.length; i++){
    if(arr[i] % 2 === 1 && arr[i + 1] % 2 === 1){
        finalStr += arr[i] + "-";
    }
    else {
        finalStr += arr[i];
    }
}

simply keep a string for the result, if two consecutive numbers are odd append an extra "-" after the number in the string, otherwise simply append the number and your final string will contain the desired result.

See the DEMO here

answered Sep 22, 2014 at 5:06

Abdul Jabbar

2,5736 gold badges28 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Abdul Jabbar Over a year ago

you're welcome and dont forget to mark the answer correct as well (:

RobG Over a year ago

The limit should be i < arr.length - 1 then just concatenate the last number at the end since there is no point in testing it. Consider: finalStr += arr[i] + (arr[i]%2 && arr[i+1]%2? '-' : '');. ;-)

Abdul Jabbar Over a year ago

@RobG you're right but that one liner would have got a little complex for any beginner to understand so i kept it as simple as i could..

Collectives™ on Stack Overflow

Looping through a string of numbers in Javascript

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related