Image Uploading to mysql database using PHP

Question

I'm trying to upload image to mysql table. When image selected it's working fine. But without selecting image it's display error message. How can i fix it?

Warning: file_get_contents(): Filename cannot be empty in C:\wamp\www\firstdialnew\firstdial\adhandler.php on line 23

$stype=$_POST['stype'];
$image = addslashes(file_get_contents($_FILES['image']['tmp_name']));
$image_name = addslashes($_FILES['image']['name']);

if($stype="")
{
echo "Please fill all the details";
}else{
$sql=mysql_query("INSERT INTO ads
                            (sid,stype,image,image_name)
                            VALUES(NULL,'$stype','$image','$image_name')");
echo "Details Successfully send";
}

The message is clear,you have nothing in $_FILES,show the part where you upload the file — Mihai
– Mihai, Commented Sep 26, 2014 at 9:59
have you tried dumping the contents of your $_FILES array - it seems you have nothing in the array thats why you are getting that message — Halfpint
– Halfpint, Commented Sep 26, 2014 at 9:59
It's a better idea to keep the image in server and store the path in database. — Mahasish
– Mahasish, Commented Sep 26, 2014 at 10:01
There are several errors. if case is incorrect; use of deprecated mysql_* functions; use of $_FILES's tmp_name; also, you didn't move your file from temp folder to final path. — Raptor
– Raptor, Commented Sep 29, 2014 at 1:56
And you shouldn't save the image contents in MySQL; save the path only. — Raptor
– Raptor, Commented Sep 29, 2014 at 2:00

Ram Sharma · Accepted Answer · 2014-09-26 10:04:09Z

3

you need to check/validate that image is upload or not try something like that

if (!empty($_FILES['image']['name'])) {
   $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));
   $image_name = addslashes($_FILES['image']['name']);
}else{
   $image = '';
   $image_name = '';
}

edited Sep 26, 2014 at 10:04

answered Sep 26, 2014 at 10:00

Ram Sharma

8,8157 gold badges48 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Raptor Over a year ago

No. You shouldn't use file_get_contents() on $_FILES.

Ryan Nghiem · Accepted Answer · 2014-09-26 10:12:34Z

1

Follow my experience, you should save image into folder (ex : public/upload/images/image_name.png) AND save image path into database. That is simple and database's size is not large

answered Sep 26, 2014 at 10:12

Ryan Nghiem

2,4482 gold badges21 silver badges31 bronze badges

1 Comment

Raptor Over a year ago

Although your suggestion is perfectly correct, this is not an answer (a comment instead).

Saqueib · Accepted Answer · 2014-09-26 10:16:25Z

1

You are not checking for $_FILES try this

$stype=$_POST['stype'];
if(isset($_FILES['image']) ) {
    $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));
    $image_name = addslashes($_FILES['image']['name']);
}else{
    $image = '';
    $image_name = '';
}

I will suggest you to upload file in a folder and store the file name in mysql table.

Here is how you can do that

$file_path = "uploads/";

if(isset($_FILES['image']) ) {
   $file_name  = basename( $_FILES['uploaded_file']['name']);
   $file_path = $file_path . $file_name;

   //You should validate the image before upload
   move_uploaded_file($_FILES['uploaded_file']['tmp_name'], $file_path);
 }else{
    $image = '';
    $image_name = '';
}

//now store file name in db
$sql=mysql_query("INSERT INTO ads
                        (sid,stype,image,image_name)
                        VALUES(NULL,'$stype','$file_name','$image_name')");

edited Sep 26, 2014 at 10:16

answered Sep 26, 2014 at 10:00

Saqueib

3,5184 gold badges36 silver badges58 bronze badges

2 Comments

Ram Sharma Over a year ago

what is the different in your answer

Raptor Over a year ago

@RamSharma this is the suggested use of $_FILES. file_get_contents() is unnecessary & move_uploaded_file() should be used.

Peter Manoukian · Accepted Answer · 2014-09-26 10:05:46Z

0

Did you add :

    <form method="POST" enctype="multipart/form-data">

Into your form (enctype="multipart/form-data")

answered Sep 26, 2014 at 10:05

Peter Manoukian

1561 silver badge13 bronze badges

1 Comment

Ram Sharma Over a year ago

I feel he is adding this because he is able to save the image but getting issue if image is not selected

Raptor · Accepted Answer · 2014-09-29 01:59:03Z

0

try this :

 $stype=$_POST['stype'];
     $image_name ='';
     $image='';
     if(!empty($_FILES['image'])) {
     $image = addslashes(file_get_contents($_FILES['image']['tmp_name']));
     $image_name = addslashes($_FILES['image']['name']);
      } 
      if($stype="")
      {
      echo "Please fill all the details";
      }else{
       $sql=mysql_query("INSERT INTO ads
                        (sid,stype,image,image_name)
                        VALUES(NULL,'$stype','$image','$image_name')");
         echo "Details Successfully send";
       }

edited Sep 29, 2014 at 1:59

Raptor

54.4k47 gold badges254 silver badges405 bronze badges

answered Sep 26, 2014 at 10:10

user3639546

1

Collectives™ on Stack Overflow

Image Uploading to mysql database using PHP

5 Answers 5

1 Comment

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related