Angular Module Loading

Question

If I have this module:

angular.module('myMod', [])
.factory('MyService', ['$http', 'Common', function ($http, Common) {
    var neededUrl = Common.myUrl;
}]);

And I loaded up my app modules this way:

angular.module('myApp', [
    'myMod'
])
.factory('Common', function () {
    return {
        myUrl: "/Some/Url"
    }
});

Will myMod be able to pick up on the Common dependency and load it up?

Or is it better to do this:

angular.module('common.module', [])
.factory('Common', function () {
    return {
        myUrl: "/Some/Url"
    }
});

angular.module('myApp', [
    'common.module',
    'myMod'
])

Remco Haszing · Accepted Answer · 2014-10-16 18:40:48Z

Both will work, but both are incorrect.

MyService from myMod depends on Common, not the other way around. Lets say you do choose to add Common to the module common.module. Then myMod should depend on common.module

angular.module('common.module', [])
.factory('Common', function () {
    return {
        myUrl: "/Some/Url"
    }
});


angular.module('myMod', [
    'common.module'
])
.factory('MyService', ['$http', 'Common', function ($http, Common) {
    var neededUrl = Common.myUrl;
}]);


angular.module('myApp', [
    'myMod'
]);

Using correct dependency management allows you to run isolated tests. The following is a jasmine example that should work:

describe('Test myMod', function() {

    beforeEach(module('myMod')); // from angular-mocks

    it('should work', function() {
        expect(true).toBeTruthy();
    })
});

If you picked either one of the options you suggested, the test case would fail, because MyService does depend on Common from common.module.

Collectives™ on Stack Overflow

Angular Module Loading

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related